Fixing ResampleLinearSpectrum method in spectrum.cpp #249
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I debugged and tested this with VS2019 16.1.3.
The problem was an index out of bounds problem where end would be -1.
This worked on all Configurations but "Release" for me. Somehow the compiler flag /Ob (Inline Function Expansion) on level 2 did something different than on level 1. (Test was working on level 1)
The access to lambdaIn[-1] returned -nan in "Release" (with /Ob2) but an tiny tiny value in all other Configurations.
I just made sure that end should never be smaller than null. Now all tests seem to work.
I didn't investigate further what the EXACT problem was, this would take too long for me now. If anyone knows the itty bitty details, please let me know.
Cheers,
Stefan