Skip to content

Conversation

stesie
Copy link
Contributor

@stesie stesie commented Mar 12, 2017

Hi Marc,

according to the README file something like vagrant run your_box your_command should work in a multi-vm environment. However "your_box" is expected to be a box uuid in that case, which is kindof cumbersome ...

this is due to checks like

command = argv[1].to_s if env.machine_index.include?(command)

... where Vagrant::MachineIndex::include? takes a UUID (meanwhile?). Maybe some API change somewhen, but haven't checked.

This patch switches behaviour to expect box names instead of UUIDs.
For me this is ok but YMMV, let me know if you'd like it to be changed to support both UUID and name.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) to 96.763% when pulling 1ef258e on stesie:fix-argv-box-name into b673fc2 on mneudert:master.

mneudert added a commit that referenced this pull request Mar 12, 2017
@mneudert
Copy link
Owner

This seems to be broken for "quite some time" without being noticed. Backported your fix to v0.7. Will probably apply the naming difference to this PR and then merge.

Could you rebase this on on top of the new master (#2 merge) for some history cleanup love?

@stesie stesie force-pushed the fix-argv-box-name branch from 1ef258e to b955d41 Compare March 12, 2017 19:07
@stesie
Copy link
Contributor Author

stesie commented Mar 12, 2017

sure, here we go

@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) to 96.548% when pulling b955d41 on stesie:fix-argv-box-name into 706e2d4 on mneudert:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) to 96.548% when pulling 92e2063 on stesie:fix-argv-box-name into 706e2d4 on mneudert:master.

@mneudert mneudert merged commit 8e14bd2 into mneudert:master Mar 13, 2017
@mneudert
Copy link
Owner

💙 💛 ❤️ 💚 💜

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants