Allow Array as :argv of chain command #2
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given a
Commandfile
like thisif I'd like to create a chain "coverage" and set parameter
cxxflags
to-O0 --coverage
andldflags
to--coverage
, ... coming from a shell background I intuitivly tried to do this (and after allvagrant run v8-5.8 configure --cxxflags="-O0 --coverage" --ldflags="--coverage"
on a shell prompt works):... but this fails.
The reason for this is that
argv
is simplyString.split
without a parameter (hence space). So it splits the argv to[ '--cxxflags="-O0', '--coverage"', '--ldflags="--coverage"' ]
... which is obviously wrong.Since I didn't want to add quotes and escape string parsing I introduced array syntax like this