Join GitHub today
stack rm should accept multiple arguments #32110
stack rm should accept multiple arguments (addresses item 2 from #30977).
Signed-off-by: Arash Deshmeh email@example.com
- What I did
- How I did it
- How to verify it
$ docker stack deploy -c ./stack.yml stack1
$ docker stack deploy -c ./stack.yml stack2
$ docker stack remove stack1 stack2
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)
Mar 26, 2017
Design LGTM, just wonder if we should do the same as
container rm or not ? (i.e. print errors at the end, but try to delete all namespace — if the first one fail, we keep the error, and return it at the end, but we still try to remove the 2nd one).
stack rm should accept multiple labels
stack rm should accept multiple arguments or
stack rm should accept multiple namespaces. Label is not the right term here I feel.
Thanks, I will change the PR so it attempts to remove all specified namespaces.
The Windows build error does not seem to be due to the changes made by the PR:
Thanks! I left some comments inline; it would also be good to have one or two examples added to the CLI docs; https://github.com/docker/docker/blob/master/docs/reference/commandline/stack_rm.md
The examples section should have its own header, you can use the
rm.md page for inspiration