New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pluggable secret backend #34123

Merged
merged 1 commit into from Jul 17, 2017

Conversation

Projects
None yet
5 participants
@liron-l
Contributor

liron-l commented Jul 15, 2017

This commit extends SwarmKit secret management with pluggable secret
backends support.

Updating the work in swarmkit for pluggable secret backend and adding the
driver parameter to SecretSpec.

Remaining work:

  • CLI support (docker/cli)
  • api in plugin helpers)
  • Reference plugin
  • Documenation (after cli work)

- What I did

- How I did it

- How to verify it

- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

@GordonTheTurtle

This comment has been minimized.

Show comment
Hide comment
@GordonTheTurtle

GordonTheTurtle Jul 15, 2017

Please sign your commits following these rules:
https://github.com/moby/moby/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:

$ git clone -b "plugable_secrets_backend" git@github.com:twistlock/docker.git somewhere
$ cd somewhere
$ git commit --amend -s --no-edit
$ git push -f

Amending updates the existing PR. You DO NOT need to open a new one.

GordonTheTurtle commented Jul 15, 2017

Please sign your commits following these rules:
https://github.com/moby/moby/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:

$ git clone -b "plugable_secrets_backend" git@github.com:twistlock/docker.git somewhere
$ cd somewhere
$ git commit --amend -s --no-edit
$ git push -f

Amending updates the existing PR. You DO NOT need to open a new one.

pluggable secret backend
This commit extends SwarmKit secret management with pluggable secret
backends support.

Updating the work in
[swarmkit](docker/swarmkit@eebac27) for
pluggable secret backend and adding the
driver parameter to `SecretSpec`.

Remaining work:
- [ ] CLI support (docker/cli)
- [ ] api in [plugin helpers](docker/go-plugins-helpers))
- [ ] Reference plugin
- [ ] Documenation (after cli work)

Signed-off-by: Liron Levin <liron@twistlock.com>
@cpuguy83

This comment has been minimized.

Show comment
Hide comment
@cpuguy83

cpuguy83 Jul 15, 2017

Contributor

Marking code review since this design was discussed in depth on swarmkit and just exposing the new features that the swarmkit API provides.

Contributor

cpuguy83 commented Jul 15, 2017

Marking code review since this design was discussed in depth on swarmkit and just exposing the new features that the swarmkit API provides.

@cpuguy83

LGTM

@aaronlehmann

This comment has been minimized.

Show comment
Hide comment
@aaronlehmann

aaronlehmann Jul 17, 2017

Contributor

LGTM

Contributor

aaronlehmann commented Jul 17, 2017

LGTM

@cpuguy83

This comment has been minimized.

Show comment
Hide comment
@cpuguy83

cpuguy83 Jul 17, 2017

Contributor

Green, 2 LGTMs. Merging

Contributor

cpuguy83 commented Jul 17, 2017

Green, 2 LGTMs. Merging

@cpuguy83 cpuguy83 merged commit 08f7cf0 into moby:master Jul 17, 2017

7 checks passed

dco-signed All commits are signed
experimental Jenkins build Docker-PRs-experimental 35684 has succeeded
Details
janky Jenkins build Docker-PRs 44301 has succeeded
Details
powerpc Jenkins build Docker-PRs-powerpc 4697 has succeeded
Details
vendor Jenkins build Docker-PRs-vendor 3600 has succeeded
Details
windowsRS1 Jenkins build Docker-PRs-WoW-RS1 15679 has succeeded
Details
z Jenkins build Docker-PRs-s390x 4376 has succeeded
Details
@thaJeztah

This comment has been minimized.

Show comment
Hide comment
@thaJeztah

thaJeztah Jul 18, 2017

Member

This needs updates to the swagger.yml and api version-history

Member

thaJeztah commented Jul 18, 2017

This needs updates to the swagger.yml and api version-history

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment