New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plugable secret backend #34157

Merged
merged 1 commit into from Jul 18, 2017

Conversation

Projects
None yet
4 participants
@liron-l
Contributor

liron-l commented Jul 18, 2017

Fixing secret driver serialization issue in secret driver (08f7cf0).

Signed-off-by: Liron Levin liron@twistlock.com

- What I did
Fixed serialization issue in secret driver.
- How I did it

- How to verify it
Verified integration with docker cli.

pluggable secret backend
Fixing secret driver serialization issue from
08f7cf0

Signed-off-by: Liron Levin <liron@twistlock.com>

@liron-l liron-l changed the title from pluggable secret backend to plugable secret backend Jul 18, 2017

@liron-l liron-l referenced this pull request Jul 18, 2017

Closed

Plugable secret backend #348

liron-l added a commit to twistlock/cli that referenced this pull request Jul 18, 2017

Plugable secret backend
This commit extends SwarmKit secret management with pluggable secret
backends support.

Following previous commits:
1. docker/swarmkit@eebac27
2. moby/moby@08f7cf0

Added driver parameter to `docker secret` command.
Specifically:
1. `docker secret create [secret_name] --driver [driver_name]`
2.  Displaying the driver in
```
    $ docker secret ls
    $ docker secret inspect [secret_name]
    $ docker secret inspect [secret_name] -pretty
```

There is a bug in serialization of the secret data. Handled in
moby/moby#34157.

Signed-off-by: Liron Levin <liron@twistlock.com>

liron-l added a commit to twistlock/cli that referenced this pull request Jul 18, 2017

Plugable secret backend
This commit extends SwarmKit secret management with pluggable secret
backends support.

Following previous commits:
1. docker/swarmkit@eebac27
2. moby/moby@08f7cf0

Added driver parameter to `docker secret` command.
Specifically:
1. `docker secret create [secret_name] --driver [driver_name]`
2.  Displaying the driver in
```
    $ docker secret ls
    $ docker secret inspect [secret_name]
    $ docker secret inspect [secret_name] -pretty
```

There is a bug in serialization of the secret data. Handled in
moby/moby#34157.

Signed-off-by: Liron Levin <liron@twistlock.com>

liron-l added a commit to twistlock/cli that referenced this pull request Jul 18, 2017

Plugable secret backend
This commit extends SwarmKit secret management with pluggable secret
backends support.

Following previous commits:
1. docker/swarmkit@eebac27
2. moby/moby@08f7cf0

Added driver parameter to `docker secret` command.
Specifically:
1. `docker secret create [secret_name] --driver [driver_name]`
2.  Displaying the driver in
```
    $ docker secret ls
    $ docker secret inspect [secret_name]
    $ docker secret inspect [secret_name] -pretty
```

There is a bug in serialization of the secret data. Handled in
moby/moby#34157.

Signed-off-by: Liron Levin <liron@twistlock.com>
@cpuguy83

Oops, LGTM

@thaJeztah

LGTM; was just looking for swagger docs when I noticed it (I'll open a PR for that)

@thaJeztah thaJeztah merged commit 0304c98 into moby:master Jul 18, 2017

6 checks passed

dco-signed All commits are signed
experimental Jenkins build Docker-PRs-experimental 35713 has succeeded
Details
janky Jenkins build Docker-PRs 44331 has succeeded
Details
powerpc Jenkins build Docker-PRs-powerpc 4709 has succeeded
Details
windowsRS1 Jenkins build Docker-PRs-WoW-RS1 15709 has succeeded
Details
z Jenkins build Docker-PRs-s390x 4408 has succeeded
Details

liron-l added a commit to twistlock/cli that referenced this pull request Jul 18, 2017

Plugable secret backend
This commit extends SwarmKit secret management with pluggable secret
backends support.

Following previous commits:
1. docker/swarmkit@eebac27
2. moby/moby@08f7cf0

Added driver parameter to `docker secret` command.
Specifically:
1. `docker secret create [secret_name] --driver [driver_name]`
2.  Displaying the driver in
```
    $ docker secret ls
    $ docker secret inspect [secret_name]
    $ docker secret inspect [secret_name] -pretty
```

There is a bug in serialization of the secret data. Handled in
moby/moby#34157.

Signed-off-by: Liron Levin <liron@twistlock.com>

liron-l added a commit to twistlock/cli that referenced this pull request Jul 18, 2017

Plugable secret backend
This commit extends SwarmKit secret management with pluggable secret
backends support.

Following previous commits:
1. docker/swarmkit@eebac27
2. moby/moby@08f7cf0

Added driver parameter to `docker secret` command.
Specifically:
1. `docker secret create [secret_name] --driver [driver_name]`
2.  Displaying the driver in
```
    $ docker secret ls
    $ docker secret inspect [secret_name]
    $ docker secret inspect [secret_name] -pretty
```

There is a bug in serialization of the secret data. Handled in
moby/moby#34157.

Signed-off-by: Liron Levin <liron@twistlock.com>

liron-l added a commit to twistlock/cli that referenced this pull request Jul 18, 2017

Plugable secret backend
This commit extends SwarmKit secret management with pluggable secret
backends support.

Following previous commits:
1. docker/swarmkit@eebac27
2. moby/moby@08f7cf0

Added driver parameter to `docker secret` command.
Specifically:
1. `docker secret create [secret_name] --driver [driver_name]`
2.  Displaying the driver in
```
    $ docker secret ls
    $ docker secret inspect [secret_name]
    $ docker secret inspect [secret_name] -pretty
```

There is a bug in serialization of the secret data. Handled in
moby/moby#34157.

Signed-off-by: Liron Levin <liron@twistlock.com>

liron-l added a commit to twistlock/cli that referenced this pull request Jul 18, 2017

Plugable secret backend
This commit extends SwarmKit secret management with pluggable secret
backends support.

Following previous commits:
1. docker/swarmkit@eebac27
2. moby/moby@08f7cf0

Added driver parameter to `docker secret` command.
Specifically:
1. `docker secret create [secret_name] --driver [driver_name]`
2.  Displaying the driver in
```
    $ docker secret ls
    $ docker secret inspect [secret_name]
    $ docker secret inspect [secret_name] -pretty
```

There is a bug in serialization of the secret data. Handled in
moby/moby#34157.

Signed-off-by: Liron Levin <liron@twistlock.com>

liron-l added a commit to twistlock/cli that referenced this pull request Jul 18, 2017

Plugable secret backend
This commit extends SwarmKit secret management with pluggable secret
backends support.

Following previous commits:
1. docker/swarmkit@eebac27
2. moby/moby@08f7cf0

Added driver parameter to `docker secret` command.
Specifically:
1. `docker secret create [secret_name] --driver [driver_name]`
2.  Displaying the driver in
```
    $ docker secret ls
    $ docker secret inspect [secret_name]
    $ docker secret inspect [secret_name] -pretty
```

There is a bug in serialization of the secret data. Handled in
moby/moby#34157.

Signed-off-by: Liron Levin <liron@twistlock.com>

liron-l added a commit to twistlock/cli that referenced this pull request Jul 18, 2017

Plugable secret backend
This commit extends SwarmKit secret management with pluggable secret
backends support.

Following previous commits:
1. docker/swarmkit@eebac27
2. moby/moby@08f7cf0

Added driver parameter to `docker secret` command.
Specifically:
1. `docker secret create [secret_name] --driver [driver_name]`
2.  Displaying the driver in
```
    $ docker secret ls
    $ docker secret inspect [secret_name]
    $ docker secret inspect [secret_name] -pretty
```

There is a bug in serialization of the secret data. Handled in
moby/moby#34157.

Signed-off-by: Liron Levin <liron@twistlock.com>

liron-l added a commit to twistlock/cli that referenced this pull request Jul 18, 2017

Plugable secret backend
This commit extends SwarmKit secret management with pluggable secret
backends support.

Following previous commits:
1. docker/swarmkit@eebac27
2. moby/moby@08f7cf0

Added driver parameter to `docker secret` command.
Specifically:
1. `docker secret create [secret_name] --driver [driver_name]`
2.  Displaying the driver in
```
    $ docker secret ls
    $ docker secret inspect [secret_name]
    $ docker secret inspect [secret_name] -pretty
```

There is a bug in serialization of the secret data. Handled in
moby/moby#34157.

Signed-off-by: Liron Levin <liron@twistlock.com>

liron-l added a commit to twistlock/cli that referenced this pull request Jul 18, 2017

Plugable secret backend
This commit extends SwarmKit secret management with pluggable secret
backends support.

Following previous commits:
1. docker/swarmkit@eebac27
2. moby/moby@08f7cf0

Added driver parameter to `docker secret` command.
Specifically:
1. `docker secret create [secret_name] --driver [driver_name]`
2.  Displaying the driver in
```
    $ docker secret ls
    $ docker secret inspect [secret_name]
    $ docker secret inspect [secret_name] -pretty
```

There is a bug in serialization of the secret data. Handled in
moby/moby#34157.

Signed-off-by: Liron Levin <liron@twistlock.com>

liron-l added a commit to twistlock/cli that referenced this pull request Jul 19, 2017

Plugable secret backend
This commit extends SwarmKit secret management with pluggable secret
backends support.

Following previous commits:
1. docker/swarmkit@eebac27
2. moby/moby@08f7cf0

Added driver parameter to `docker secret` command.
Specifically:
1. `docker secret create [secret_name] --driver [driver_name]`
2.  Displaying the driver in
```
    $ docker secret ls
    $ docker secret inspect [secret_name]
    $ docker secret inspect [secret_name] -pretty
```

There is a bug in serialization of the secret data. Handled in
moby/moby#34157.

Signed-off-by: Liron Levin <liron@twistlock.com>

liron-l added a commit to twistlock/cli that referenced this pull request Jul 19, 2017

Plugable secret backend
This commit extends SwarmKit secret management with pluggable secret
backends support.

Following previous commits:
1. docker/swarmkit@eebac27
2. moby/moby@08f7cf0

Added driver parameter to `docker secret` command.
Specifically:
1. `docker secret create [secret_name] --driver [driver_name]`
2.  Displaying the driver in
```
    $ docker secret ls
    $ docker secret inspect [secret_name]
    $ docker secret inspect [secret_name] -pretty
```

There is a bug in serialization of the secret data. Handled in
moby/moby#34157.

Signed-off-by: Liron Levin <liron@twistlock.com>

liron-l added a commit to twistlock/cli that referenced this pull request Jul 19, 2017

Plugable secret backend
This commit extends SwarmKit secret management with pluggable secret
backends support.

Following previous commits:
1. docker/swarmkit@eebac27
2. moby/moby@08f7cf0

Added driver parameter to `docker secret` command.
Specifically:
1. `docker secret create [secret_name] --driver [driver_name]`
2.  Displaying the driver in
```
    $ docker secret ls
    $ docker secret inspect [secret_name]
    $ docker secret inspect [secret_name] -pretty
```
3. Add driver parameter to secrets in `docker-compose`.

There is a bug in serialization of the secret data. Handled in
moby/moby#34157.

Signed-off-by: Liron Levin <liron@twistlock.com>

liron-l added a commit to twistlock/cli that referenced this pull request Jul 19, 2017

Plugable secret backend
This commit extends SwarmKit secret management with pluggable secret
backends support.

Following previous commits:
1. docker/swarmkit@eebac27
2. moby/moby@08f7cf0

Added driver parameter to `docker secret` command.
Specifically:
1. `docker secret create [secret_name] --driver [driver_name]`
2.  Displaying the driver in
```
    $ docker secret ls
    $ docker secret inspect [secret_name]
    $ docker secret inspect [secret_name] -pretty
```
3. Add driver parameter to secrets in `docker-compose`.

There is a bug in serialization of the secret data. Handled in
moby/moby#34157.

Signed-off-by: Liron Levin <liron@twistlock.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment