[23.0 backport] graphdriver/overlay2: usingMetacopy ENOTSUP is non-fatal #44922
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
Change
usesMetacopy
inoverlay2
'scheck.go
to return false/no error on aENOTSUP
in lgetxattr(2).- How to verify it
By reading kernel documentation, more or less. ENOTSUP does not indicate that something went wrong, but that either the xattr in question, or xattr as a whole, are not supported by the filesystem.
- Description for the changelog
overlay2
storage driver failing in a check for metacopy status instead of backing FS compatibility on incompatible backing filesystems.- A picture of a cute animal (not mandatory but encouraged)