Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[23.0 backport] graphdriver/overlay2: usingMetacopy ENOTSUP is non-fatal #44922

Merged
merged 1 commit into from
Feb 4, 2023

Conversation

neersighted
Copy link
Member

- What I did
Change usesMetacopy in overlay2's check.go to return false/no error on a ENOTSUP in lgetxattr(2).

- How to verify it
By reading kernel documentation, more or less. ENOTSUP does not indicate that something went wrong, but that either the xattr in question, or xattr as a whole, are not supported by the filesystem.

- Description for the changelog

  • Fix the overlay2 storage driver failing in a check for metacopy status instead of backing FS compatibility on incompatible backing filesystems.

- A picture of a cute animal (not mandatory but encouraged)
image

Signed-off-by: Bjorn Neergaard <bneergaard@mirantis.com>
(cherry picked from commit 3bcb350)
Signed-off-by: Bjorn Neergaard <bneergaard@mirantis.com>
@neersighted neersighted added this to the 23.0.1 milestone Feb 4, 2023
@thaJeztah thaJeztah changed the title graphdriver/overlay2: usingMetacopy ENOTSUP is non-fatal [23.0 backport] graphdriver/overlay2: usingMetacopy ENOTSUP is non-fatal Feb 4, 2023
Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@thaJeztah
Copy link
Member

@cpuguy83 @corhere ptal

@cpuguy83 cpuguy83 merged commit 7df2649 into moby:23.0 Feb 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants