Do not force exit of a process (by default) #2879

medikoo · 2017-06-12T13:43:55Z

I'm talking about behaviour that can be switched off with --no-exit option.

Having this as default looks dangerous, as it may hide serious issues in tests (any orphaned async flow is just silenced, leaving no clue to developer)

e.g. on my side I had a promise with crashing test not returned properly. Still test process as handled by mocha was exiting smiling with a success. It took me a while to figure out why it happens.

The text was updated successfully, but these errors were encountered:

michaelBenin · 2017-06-12T14:27:24Z

@medikoo did you try having a call to done() in the test and increase the timeout?

medikoo · 2017-06-12T15:16:13Z

@michaelBenin no, it was a setup issue, it was orphaned async flow not provided to mocha as documented.

So describe block ended with no test being run, while there were scheduled ones and what's worse, the scheduled ones were failing.

But fact that API was misused should be irrelevant, what's relevant is that background async tasks (which in the end would crash) where just aborted cause of forced process exit. Especially test suites should not do this.

michaelBenin · 2017-06-12T18:21:09Z

In my tests I have a teardown util which is the last test to be run. Would something like this benefit you?

medikoo · 2017-06-13T06:22:44Z

@michaelBenin this issue is about silencing eventual errors in configuration which in normal cricumstances will explicitly crash (and that way become apparent).

Otherwise once spotted, those errors are easy to fix, there's no problem with that.

ScottFreeCode · 2017-06-13T09:40:47Z

See also #1855 for a potential caveat about eventually timing out so this doesn't lead to just sitting waiting on anything that keeps the process open forever.

medikoo · 2017-06-13T09:57:51Z

so this doesn't lead to just sitting waiting on anything that keeps the process open forever.

In my opinion tests always should come up with proper cleanup. If effect of a test is that process is kept forever then it is a clear issue with a test or a functionality that's being tested. I believe it's quite important that such issues are exposed to the developer

ScottFreeCode · 2017-09-28T15:11:38Z

If we want to get this in V4, it should be a simple matter of switching the default for the parameter... right?

Allows `--exit` to override and force exit as before. Resolves #2879

See mochajs/mocha#2879 to understand how these are linked.

maximilianschmitt · 2017-11-14T17:44:35Z

Hi, we're looking to update to mocha 4 and think this is a great change.

However, is there a way to tell when mocha intends to exit / all tests are done? We have some setup-code that spawns a server that is used across multiple test suites (so before(), after() don't work for that). Thanks!

boneskull · 2017-11-14T23:07:10Z

@maximilianschmitt I would suggest opening a server in a separate process

ScottFreeCode · 2017-11-15T06:28:29Z

Global ("root-level") before and after, i.e. the ones outside any describe, should run at the very beginning and very end of Mocha's test run.

maximilianschmitt · 2017-11-23T13:01:54Z

Thanks @ScottFreeCode , that should do it! :)

Allows `--exit` to override and force exit as before. Resolves mochajs#2879

Use NPM scripts to run coffeelint - Update coffeelint to 2.1.0 Also update Coffeescript and explictly depends on version 2, Use `undefined` as default argument instead of null, it's breaking changes on Coffescript 2. See: - https://coffeescript.org/#breaking-changes-default-values - jashkenas/coffeescript#2201 - Remove grunt and its plugins inlcude grunt-coffeelint, grunt-contrib-coffee and grunt-mocha-cov, Remove Gruntfile.coffee by using NPM scripts, and remove path of "npm bin" in scripts, Because the command of "npm run" adds node_modules/.bin to the PATH provided to scripts automatically. - Update vulnerable dependencies include socket.io, chokidar - Explictly depends on mocha Add --exit flag "By default, Mocha will no longer force the process to exit once all tests complete. This means any test code (or code under test) which would normally prevent node from exiting will do so when run in Mocha. Supply the --exit flag to revert to pre-v4.0.0 behavior" mochajs/mocha#2879 https://mochajs.org/#-exit - Use c8 to output coverage instead of blanket - Add generate-examples scripts To replace 'gen-examples' task defined in Gruntfile

…chacli options To force shutdown of the event loop after test run From v4.0.0, grunt-mocha-cli use mocha v4.0.0 which no logger use '--no-exit' flag By default, Mocha will no longer force the process to exit once all tests complete. This means any test code (or code under test) which would normally prevent node from exiting will do so when run in Mocha. Supply the --exit flag to revert to pre-v4.0.0 behavior Check breaking change: https://github.com/mochajs/mocha/releases/tag/v4.0.0 The reported Github issue: mochajs/mocha#2879

this is a mochas issue . mochajs/mocha#2879 This might be better on the long run to simply update dependency version

mochajs/mocha#2879

ScottFreeCode added status: accepting prs Mocha can use your help with this one! semver-major implementation requires increase of "major" version number; "breaking changes" labels Jun 13, 2017

medikoo mentioned this issue Aug 24, 2017

Fix tests setup - ensure errors are exposed serverless/serverless#4139

Merged

ScottFreeCode mentioned this issue Sep 26, 2017

setTimeout() after done() is called (--watch mode) #3014

Closed

ScottFreeCode added a commit that referenced this issue Sep 29, 2017

Switch default from forced exit to no-exit

a3e32de

Allows `--exit` to override and force exit as before. Resolves #2879

ScottFreeCode mentioned this issue Sep 29, 2017

Switch default from forced exit to no-exit #3034

Merged

ScottFreeCode added a commit that referenced this issue Sep 29, 2017

Switch default from forced exit to no-exit

2b6991f

Allows `--exit` to override and force exit as before. Resolves #2879

boneskull mentioned this issue Sep 30, 2017

add integration tests for --exit / --no-exit behavior #3039

Merged

boneskull pushed a commit that referenced this issue Sep 30, 2017

Switch default from forced exit to no-exit

7278119

Allows `--exit` to override and force exit as before. Resolves #2879

boneskull closed this as completed in #3034 Oct 1, 2017

boneskull pushed a commit that referenced this issue Oct 1, 2017

Switch default from forced exit to no-exit

3fdd3ff

Allows `--exit` to override and force exit as before. Resolves #2879

boneskull mentioned this issue Oct 1, 2017

Warning: Express' tests break under forthcoming Mocha v4.0.0 expressjs/express#3439

Closed

mceachen mentioned this issue Oct 3, 2017

mocha 4 doesn't exit unlike mocha 3 #3044

Closed

1 task

siburny mentioned this issue Oct 9, 2017

the grunt execution is stuck pocesar/grunt-mocha-istanbul#71

Closed

cklanac mentioned this issue Oct 14, 2017

Http Server not closing after tests chaijs/chai-http#178

Closed

paulmelnikow pushed a commit to IcedFrisby/IcedFrisby that referenced this issue Oct 19, 2017

Clean up after userApp() and upgrade to the latest Mocha (#72)

057b888

See mochajs/mocha#2879 to understand how these are linked.

TheAdamizer mentioned this issue Oct 24, 2017

NYC hanging when updating mocha to 4.0.1 istanbuljs/nyc#688

Closed

dignifiedquire mentioned this issue Oct 25, 2017

fix: add exit option back to fix buggy tests ipfs/aegir#163

Merged

devpascoe mentioned this issue Dec 1, 2017

Close server after tests ladjs/supertest#437

Open

renovate bot mentioned this issue Oct 5, 2018

Update dependency mocha to v5 renovate-mirrors/revolutionuc-website#6

Open

1 task

renovate bot mentioned this issue Nov 1, 2018

Update dependency mocha to v5 justinbarry/augur-copy#93

Merged

This was referenced Nov 14, 2018

Update dependency mocha to v5 hairyhenderson/nursery_alert#17

Merged

fix(deps): update dependency @types/mocha to v5 - autoclosed stefanwalther/boilerplate-typescript-rest-docker#18

Closed

renovate bot mentioned this issue Nov 23, 2018

chore(deps): update dependency mocha to v5 JLHwung/tianzige#37

Merged

This was referenced Dec 1, 2018

chore(deps): update dependency mocha to v5 - autoclosed stefanwalther/qix-graphql#66

Closed

Update dependency mocha to v5 softbrix/stureby-index#4

Merged

Update dependency mocha to v5 Automattic/jetpack#10877

Merged

This was referenced Dec 8, 2018

Update dependency @types/mocha to v5 - autoclosed tomyitav/apollo-typed-lambda#12

Closed

Update dependency mocha to v5 softbrix/dibba-tree#5

Merged

This was referenced Dec 23, 2018

Update dependency mocha to v5 - autoclosed mateodelnorte/microsvc-slave#7

Closed

chore(deps): update dependency mocha to v5 status-board/status-board-cli#175

Closed

markwolff mentioned this issue Jan 11, 2019

Perform UnitTest with real application insights too long microsoft/ApplicationInsights-node.js#475

Closed

sgilroy pushed a commit to TwineHealth/mocha that referenced this issue Feb 27, 2019

Switch default from forced exit to no-exit

e52d203

Allows `--exit` to override and force exit as before. Resolves mochajs#2879

kanedafromparis added a commit to kanedafromparis/nodejs-ex that referenced this issue Dec 10, 2019

add --exit

140c0e6

this is a mochas issue . mochajs/mocha#2879 This might be better on the long run to simply update dependency version

codingthat mentioned this issue Apr 29, 2021

Async Express.js function with invalid reference hangs Mocha without an error or stack trace #4632

Closed

4 tasks

Eandalf7h added a commit to Eandalf7h/graphql that referenced this issue Nov 27, 2021

mocha >= 4.0 correctly reports unhandledRejection on its own

89e154b

mochajs/mocha#2879

hiukky7e added a commit to hiukky7e/graphqlb that referenced this issue Nov 27, 2021

mocha >= 4.0 correctly reports unhandledRejection on its own

05a79b9

mochajs/mocha#2879

andygout mentioned this issue Sep 28, 2022

Upgrade mocha ^3.2.0 -> ^10.0.0 andygout/dramatis-api#492

Merged

jonathan-briere added a commit to jonathan-briere/swapi-graphql that referenced this issue Jul 4, 2023

mocha >= 4.0 correctly reports unhandledRejection on its own

cc6bd58

mochajs/mocha#2879

darkhorse941019 pushed a commit to darkhorse941019/express-graphql that referenced this issue Sep 29, 2024

mocha >= 4.0 correctly reports unhandledRejection on its own

f5657c4

mochajs/mocha#2879

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Do not force exit of a process (by default) #2879

Do not force exit of a process (by default) #2879

medikoo commented Jun 12, 2017 •

edited

Loading

michaelBenin commented Jun 12, 2017

medikoo commented Jun 12, 2017

michaelBenin commented Jun 12, 2017

medikoo commented Jun 13, 2017 •

edited

Loading

ScottFreeCode commented Jun 13, 2017

medikoo commented Jun 13, 2017 •

edited

Loading

ScottFreeCode commented Sep 28, 2017

maximilianschmitt commented Nov 14, 2017

boneskull commented Nov 14, 2017

ScottFreeCode commented Nov 15, 2017

maximilianschmitt commented Nov 23, 2017

Do not force exit of a process (by default) #2879

Do not force exit of a process (by default) #2879

Comments

medikoo commented Jun 12, 2017 • edited Loading

michaelBenin commented Jun 12, 2017

medikoo commented Jun 12, 2017

michaelBenin commented Jun 12, 2017

medikoo commented Jun 13, 2017 • edited Loading

ScottFreeCode commented Jun 13, 2017

medikoo commented Jun 13, 2017 • edited Loading

ScottFreeCode commented Sep 28, 2017

maximilianschmitt commented Nov 14, 2017

boneskull commented Nov 14, 2017

ScottFreeCode commented Nov 15, 2017

maximilianschmitt commented Nov 23, 2017

medikoo commented Jun 12, 2017 •

edited

Loading

medikoo commented Jun 13, 2017 •

edited

Loading

medikoo commented Jun 13, 2017 •

edited

Loading