feat(runner): fix '.only()' exclusive feature, #1481

[a8m]

This PR fix #1481, and also extends the .only() behaviour.
e.g:

• it's not use grep anymore
• support suite, test-case or both.
• add the ability to run multiple .only() (on many files)

There's a tests for bdd, tdd and qunit interfaces that illustrate the point more clearly. so please take a look on it, and let me now what do you think.

[boneskull]

@a8m Thanks! Hopefully someone will check this out soon--I'm going to be swamped for next few wks still. I'm thinking might be good for 3.0.0 release

[a8m]

Great @boneskull
/cc @travisjeffery @dasilvacontin

[erezesk]

@a8m looks great, tyvm!
+1

[dasilvacontin]

Very busy lately, I'll try to dedicate some time to mocha this weekend. Anyways, thanks for the amazing work you've been pushing, @a8m! :)

[travisjeffery]

looks pretty good, i've looked it over quickly a couple of times and got the feeling some parts could be simpler/clearer. i should get sometime tomorrow to look more in-depth

[a8m]

Great @travisjeffery
thx

[danielstjules]

Looks pretty good! Works with almost all my tests, though I think I found a couple edge cases. The first is with the root suite I think:

describe.only('suite', function() {
  it.only('test', function() {});

  it('test2', function() {});
});

it('should not be ran', function() {});

it.only('another test', function() {});

danielstjules:~/git/mocha (pr1591)
$ ./bin/mocha --reporter spec example.js


  ✓ should not be ran
  ✓ another test
  suite
    ✓ test


  3 passing (10ms)

On master, however, I get the following:

danielstjules:~/git/mocha (master =)
$ ./bin/mocha --reporter spec example.js


  ✓ another test

  1 passing (6ms)

I think it was decided in the issue that spec-related only just take precedence over suite level, so with that in mind, should the correct output of this suite be:

  ✓ another test
  suite
    ✓ test


  2 passing (11ms)

[danielstjules]

The second issue I hit was with the following test:

describe.only('suite', function() {
  it.only('test', function() {});

  it('test2', function() {});

  describe('suite2', function() {
    it('test3', function() {});
  });
});

danielstjules:~/git/mocha (pr1591)
$ ./bin/mocha --reporter spec example.js


  0 passing (3ms)

[a8m]

haha, I forgot to test the root suite, it should be fix here. I'll do it.
about the second example, I'll play with it and see what happens
thx @danielstjules

[a8m]

Fixed!
PTAL @danielstjules

[danielstjules]

Those 2 look good, awesome!

Got another example, though I don't know if this is expected behavior or not. So this is probably not a bug, but just wanted to clarify :)

describe.only('suite', function() {
  describe('inner', function() {
    it.only('test', function() {});

    it('should not run', function() {});
  });

  it('should not run either', function() {});
});

dstjules:~/git/mocha (pr1591)
$ ./bin/mocha --reporter spec example.js


  suite
    ✓ should not run either
    inner
      ✓ test


  2 passing (8ms)

Is that expected output? If so, then the rest looks good to me!

[a8m]

This is the expected behaviour, PTAL bdd-test
Thanks for a agreat CR @danielstjules

[a8m]

rebased!

[dasilvacontin]

These comments have a few typos.

[dasilvacontin]

@a8m, in general, you are writing if(val) instead of if (val).

[dasilvacontin]

Maybe we can set this now to Boolean?

[dasilvacontin]

LGTM 👍.

@travisjeffery, were you going to suggest any code improvements?

[a8m]

ping @mochajs/mocha

[dasilvacontin]

Well, goes.

[dasilvacontin]

We'll have to wait for the v3.0.0 release tho.

[boneskull]

@a8m I haven't gotten a chance to look at this yet, but please let me before this gets merged.

cc @mochajs/mocha

[boneskull]

various places in this PR will need to be linted

[a8m]

Replaced with #1807(rebased on top of v3.0.0)

[Vanuan]

WTF? Are you trying to fix all bugs with one PR? Release some fix already.

[boneskull]

@Vanuan I understand you are probably frustrated with the .only() bug(s), but please try to be constructive. Thanks!