feat: handle SSE comment messages #467
Merged
+9
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add support for ignoring SSE comment lines that start with ':' - Add debug logging for comment line processing Resolves modelcontextprotocol#443 Signed-off-by: Christian Tzolov <christian.tzolov@broadcom.com>
|
back-ported to 0.11.2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #443
Add support for handling SSE comment messages starting with ":" in ResponseSubscribers
Motivation and Context
This change implements proper handling of Server-Sent Events (SSE) comment lines according to the SSE specification. SSE streams can contain comment lines that start with ":" which should be ignored during processing. Previously, these comment lines were not explicitly handled, which could lead to parsing issues or unexpected behavior when processing SSE streams.
How Has This Been Tested?
Breaking Changes
No breaking changes. This is a backward-compatible enhancement that adds proper handling for SSE comment lines without affecting existing functionality.
Types of changes
Checklist