Skip to content

feat: handle SSE comment messages #467

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 7, 2025
+9 −0
Merged

feat: handle SSE comment messages #467

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions mcp/src/main/java/io/modelcontextprotocol/client/transport/ResponseSubscribers.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,8 @@

import org.reactivestreams.FlowAdapters;
import org.reactivestreams.Subscription;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;

import io.modelcontextprotocol.spec.McpError;
import reactor.core.publisher.BaseSubscriber;
Expand All @@ -31,6 +33,8 @@
*/
class ResponseSubscribers {

private static final Logger logger = LoggerFactory.getLogger(ResponseSubscribers.class);

record SseEvent(String id, String event, String data) {
}

Expand Down Expand Up @@ -167,6 +171,11 @@ else if (line.startsWith("event:")) {
this.currentEventType.set(matcher.group(1).trim());
}
}
else if (line.startsWith(":")) {
// Ignore comment lines starting with ":"
// This is a no-op, just to skip comments
logger.debug("Ignoring comment line: {}", line);
}
else {
// If the response is not successful, emit an error
// TODO: This should be a McpTransportError
Expand Down