Reworked app update flow #3960
Merged
Reworked app update flow #3960
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexTMjugador
approved these changes
Jul 15, 2025
IMB11
approved these changes
Jul 15, 2025
Prospector
approved these changes
Jul 17, 2025
|
would be good to double check my latest changes didn't break functionality, requested another review from @IMB11 Feel free to queue for merge if it looks good to you |
|
Out of interest, what's blocking this? |
IMB11
approved these changes
Sep 24, 2025
# Conflicts: # .cargo/config.toml
Prospector
approved these changes
Sep 29, 2025
IMB11
approved these changes
Sep 29, 2025
auto-merge was automatically disabled
September 29, 2025 15:37
Pull Request is not mergeable
fetchfern
pushed a commit
that referenced
this pull request
Oct 1, 2025
* Make theseus capable of logging messages from the `log` crate * Move update checking entirely into JS and open a modal if an update is available * Fix formatjs on Windows and run formatjs * Add in the buttons and body * Fix lint * Show update size in modal * Fix update not being rechecked if the update modal was directly dismissed * Slight UI tweaks * Fix lint * Implement skipping the update * Implement the Update Now button * Implement updating at next exit * Turn download progress into an error bar on failure * Restore 5 minute update check instead of 30 seconds * Fix PendingUpdateData being seen as a unit struct * Fix lint * Make CI also lint updater code * feat: create AppearingProgressBar component * feat: polish update available modal * feat: add error handling * Open changelog with tauri-plugin-opener * Run intl:extract * Update completion toasts (#3978) * Use single LAUNCHER_USER_AGENT constant for all user agents * Fix build on Mac * Request the update size with HEAD instead of GET * UI tweaks * lint * Fix lint * fix: hide modal header & add "Hide update reminder" button w/ tooltip * Run intl:extract * fix: lint issues * fix: merge issues * notifications.js no longer exists * Add metered network checking * Add a timeout to macOS is_network_metered * Fix tauri.conf.json * vibe debugging * Set a dispatch queue * Have a popup that asks you if you'd like to disable automatic file downloads if you're on a metered network * Move UpdateModal to modal package * Fix lint * Add a toggle for automatic downloads * Fix type Co-authored-by: Alejandro González <7822554+AlexTMjugador@users.noreply.github.com> Signed-off-by: Josiah Glosson <soujournme@gmail.com> * Redo updating UI and experience * lint * fix unlistener issue * remove unneeded translation keys * Fix expose issue * temp disable cranelift, tweak some messages * change version back * Clean up App.vue * move toast to top right * update reload icon * Fixed the bug!!!!!!!!!!!! * improve messages * intl:extract * Add liquid glass icon file * not you! * use dependency injection * lint on apple icon * Fix imports, move download size to button * change update check back to 5 mins * lint + move to providers * intl:extract --------- Signed-off-by: Cal H. <hendersoncal117@gmail.com> Signed-off-by: Josiah Glosson <soujournme@gmail.com> Co-authored-by: Calum <calum@modrinth.com> Co-authored-by: Prospector <prospectordev@gmail.com> Co-authored-by: Cal H. <hendersoncal117@gmail.com> Co-authored-by: Prospector <6166773+Prospector@users.noreply.github.com> Co-authored-by: Alejandro González <7822554+AlexTMjugador@users.noreply.github.com>
AlexTMjugador
added a commit
that referenced
this pull request
Oct 4, 2025
PR #3960 reverted the Cranelift usage introduced in #4388 due to its codegen not being up to standard when compiling some pieces of code under some platforms. However, it didn't revert the switch to a nightly Rust toolchain, which is now unnecessary, and produces unnecessary drift between what's declared in the `rust-toolchain.toml` and the Docker image manifests, causing inefficiencies. These changes bring back the usage of stable Rust for the time being to correct those inefficiencies.
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 4, 2025
PR #3960 reverted the Cranelift usage introduced in #4388 due to its codegen not being up to standard when compiling some pieces of code under some platforms. However, it didn't revert the switch to a nightly Rust toolchain, which is now unnecessary, and produces unnecessary drift between what's declared in the `rust-toolchain.toml` and the Docker image manifests, causing inefficiencies. These changes bring back the usage of stable Rust for the time being to correct those inefficiencies.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The old app updater automatically installed new updates immediately on startup with no user involvement or consent. This reworks it to have a new modal that asks whether the user would like to update now, update on next restart, or skip this update.
Closes DEV-128
Closes DEV-229