Use Nightly + Cranelift for dev, only fail on warnings in CI #4388
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aecsocket
commented
Sep 18, 2025
| #[serde(default = "HashMap::new")] | ||
| pub file_types: HashMap<String, Option<FileType>>, | ||
| } | ||
|
|
There was a problem hiding this comment.
Idk how this wasn't triggering a dead code warning before, but apparently this is unused. On standard codegen this doesn't emit a warning. On cranelift this does.
aecsocket
commented
Sep 18, 2025
| Self::StaleWhileRevalidateSkipOffline | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
Also don't know how this wasn't caught on main CI.
There was a problem hiding this comment.
That is most likely explained due to the usage of different Rust versions. Nightly's Clippy is ahead of stable when it comes to new lints (and regressions).
aecsocket
force-pushed
the
boris/toolchain-improvement
branch
from
3f2ad4e to
137f338
Compare
fetchfern
reviewed
Sep 18, 2025
AlexTMjugador
added a commit
that referenced
this pull request
Oct 4, 2025
PR #3960 reverted the Cranelift usage introduced in #4388 due to its codegen not being up to standard when compiling some pieces of code under some platforms. However, it didn't revert the switch to a nightly Rust toolchain, which is now unnecessary, and produces unnecessary drift between what's declared in the `rust-toolchain.toml` and the Docker image manifests, causing inefficiencies. These changes bring back the usage of stable Rust for the time being to correct those inefficiencies.
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 4, 2025
PR #3960 reverted the Cranelift usage introduced in #4388 due to its codegen not being up to standard when compiling some pieces of code under some platforms. However, it didn't revert the switch to a nightly Rust toolchain, which is now unnecessary, and produces unnecessary drift between what's declared in the `rust-toolchain.toml` and the Docker image manifests, causing inefficiencies. These changes bring back the usage of stable Rust for the time being to correct those inefficiencies.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cranelift has much faster incremental recompiles, which helps when iterating on labrinth features.
Warnings are currently denied in the root Cargo.toml, which is good for rigorous CI but is annoying when quickly prototyping features and you don't mind some dead code or unused imports. This PR keeps warnings as warnings, but passes
-Dwarningsin the CI test run to fail on warnings there.