-
Notifications
You must be signed in to change notification settings - Fork 337
Use Nightly + Cranelift for dev, only fail on warnings in CI #4388
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
bfdb414
2145dae
ec113f8
d003160
049586a
137f338
6c26810
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,9 +1,16 @@ | ||
# Enable Cranelift for debug builds, improving iterative compile times | ||
[unstable] | ||
codegen-backend = true | ||
|
||
[profile.dev] | ||
codegen-backend = "cranelift" | ||
|
||
[build] | ||
rustflags = ["--cfg", "tokio_unstable"] | ||
|
||
# Windows has stack overflows when calling from Tauri, so we increase the default stack size used by the compiler | ||
[target.'cfg(windows)'] | ||
rustflags = ["-C", "link-args=/STACK:16777220", "--cfg", "tokio_unstable"] | ||
rustflags = ["--cfg", "tokio_unstable", "-C", "link-args=/STACK:16777220"] | ||
|
||
[target.x86_64-pc-windows-msvc] | ||
linker = "rust-lld" | ||
|
||
[build] | ||
rustflags = ["--cfg", "tokio_unstable"] |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -519,11 +519,14 @@ impl CacheValue { | |
} | ||
} | ||
|
||
#[derive(Deserialize, Serialize, PartialEq, Eq, Debug, Copy, Clone)] | ||
#[derive( | ||
Deserialize, Serialize, PartialEq, Eq, Debug, Copy, Clone, Default, | ||
)] | ||
#[serde(rename_all = "snake_case")] | ||
pub enum CacheBehaviour { | ||
/// Serve expired data. If fetch fails / launcher is offline, errors are ignored | ||
/// and expired data is served | ||
#[default] | ||
StaleWhileRevalidateSkipOffline, | ||
// Serve expired data, revalidate in background | ||
StaleWhileRevalidate, | ||
|
@@ -533,12 +536,6 @@ pub enum CacheBehaviour { | |
Bypass, | ||
} | ||
|
||
impl Default for CacheBehaviour { | ||
fn default() -> Self { | ||
Self::StaleWhileRevalidateSkipOffline | ||
} | ||
} | ||
|
||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Also don't know how this wasn't caught on main CI. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. That is most likely explained due to the usage of different Rust versions. Nightly's Clippy is ahead of stable when it comes to new lints (and regressions). |
||
#[derive(Debug, Clone, Serialize, Deserialize)] | ||
pub struct CachedEntry { | ||
id: String, | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,2 +1,9 @@ | ||
[toolchain] | ||
channel = "1.89.0" | ||
channel = "nightly-2025-09-18" | ||
profile = "default" | ||
components = [ | ||
"rust-analyzer", | ||
# use cranelift in debug builds to improve compile times | ||
# also see `.cargo/config.toml` | ||
"rustc-codegen-cranelift-preview" | ||
] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Idk how this wasn't triggering a dead code warning before, but apparently this is unused. On standard codegen this doesn't emit a warning. On cranelift this does.