This repository has been archived by the owner on Aug 3, 2024. It is now read-only.
fix(project): update follower count client side #1038
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
triphora
reviewed
Mar 11, 2023
|
Maybe, I just Saw the composables files as they should only have Logic relater to the name/file so user in this case, where incrementing and decrementing is not user related but more page specific in My mind. |
|
tbh, I don't know how it's "supposed to be" separated. In any event, incrementing and decrementing is going to be wanted no matter which page it's on. |
|
Moved to user composable |
triphora
approved these changes
Mar 12, 2023
Morb0
pushed a commit
to CorvaxStation/knossos
that referenced
this pull request
Jun 30, 2023
* fix(project): update follower count client side * move following increment to user composable --------- Co-authored-by: MagnusHJensen <magnus.holm.jensen@lego.dk>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Ensures the project followers on the client side is in-sync with the actions taken.
Media:
Screen.Recording.2023-03-11.at.11.59.42.mov
Closes: modrinth/code#1912