Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invoke system events on failed login attempts #12351

Closed
wants to merge 1 commit into from

Conversation

bequadrat
Copy link

Invoke OnWebAuthenticationFailed / OnManagerAuthenticationFailed system events on failed login attempts, to enable plugins to react to login errors (e.g. write them to a log file). Requires the two new events to be added to the system_eventnames database table. Resolves #12207.

Invoke OnWebAuthenticationFailed / OnManagerAuthenticationFailed system events on failed login attempts, to enable plugins to react to login errors (e.g. write them to a log file)
@theboxer
Copy link
Member

Hello @bequadrat,
this should be proposed to develop branch. The PR also misses creating new events, so they are available for plugins.

Can you please fix those problems and submit the PR again (and follow https://github.com/modxcms/revolution/blob/master/CONTRIBUTING.md especially the part about CLA and PR template)?

@theboxer theboxer closed this Feb 10, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants