Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#828: Integrate Sidecar for Transaction Request Service #288

Merged
merged 13 commits into from
Mar 23, 2020
Merged

#828: Integrate Sidecar for Transaction Request Service #288

merged 13 commits into from
Mar 23, 2020

Conversation

oderayi
Copy link
Collaborator

@oderayi oderayi commented Mar 16, 2020 •
edited
Loading

  • Integrate Sidecar for TRS
  • Update deployment.yml with new environment variables
  • Other minor fixes

@mdebarros mdebarros mentioned this pull request Mar 16, 2020
Closed
36 tasks
@rmothilal
Copy link
Contributor

@oderayi I think you were supposed to integrate the event sidecar into the TRS, not the forensic-logging sidecar which is a library we no longer use @elnyry please confirm if I have this correct

rmothilal
rmothilal requested changes Mar 16, 2020
View reviewed changes
Copy link
Contributor

@rmothilal rmothilal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@oderayi I think you have mistaken event-sidecar with forensic-logging sidecar. this should not be the case

@oderayi oderayi requested a review from rmothilal March 19, 2020 15:14
rmothilal
rmothilal previously approved these changes Mar 20, 2020
View reviewed changes
Copy link
Contributor

@rmothilal rmothilal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy

@oderayi oderayi requested a review from rmothilal March 23, 2020 10:49
@oderayi oderayi merged commit 8356dd7 into mojaloop:master Mar 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elnyry-sam-k elnyry-sam-k elnyry-sam-k approved these changes

@mdebarros mdebarros Awaiting requested review from mdebarros

@rmothilal rmothilal Awaiting requested review from rmothilal

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@oderayi @rmothilal @elnyry-sam-k