Missing Error code for the transfer in the Central ledger DB

[sri-miriyala]

Summary:
When the Transfer is expired with an error code "3303", that error code is not getting stored in the DB. This was found when the BizOps portal is trying to pull the error transfers based on the error codes. This transfer did not picked up in the error cases.

Severity:
Medium

Priority:
Critical

Expected Behavior
The error code should be assigned for every transfer that is failed (ABORTED)

Steps to Reproduce

1. Check the logs for this transfer ID: 2b8666c9-8905-434b-aa19-98521f34966c

Specifications

• Component (if known): Central Ledger
• Version:
• Platform: OSS infra test env
• Subsystem:
• Type of testing:
• Bug found/raised by: Sri

Notes:

• Severity when opened:
• Priority when opened:

[mdebarros]

Verified this issue using the following GP test on Moja1 --> hub/golden_path/feature_tests/transfer_negative_scenarios/fulfil-reserved-v1.0.json

Callback

{
  "url": "put /transfers/a38f9269-9249-467b-96f3-48b2ed7261cc/error",
  "headers": {
    "content-type": "application/vnd.interoperability.transfers+json;version=1.1",
    "date": "Wed, 19 Jan 2022 08:31:38 GMT",
    "authorization": "{$inputs.TTK_BEARER_TOKEN}",
    "traceparent": "00-aabbdc555b3acee9361afafab3942ed7-38598b9779f73959-30",
    "user-agent": "axios/0.21.4",
    "connection": "keep-alive",
    "fspiop-http-method": "PUT",
    "fspiop-uri": "/transfers/a38f9269-9249-467b-96f3-48b2ed7261cc/error",
    "fspiop-source": "switch",
    "fspiop-destination": "testingtoolkitdfsp",
    "fspiop-signature": "{\"signature\":\"yhZcNwjGi0SxeauL66j9F9YSrKbkgVXgsqrWQKr3cAFfBJp43LEHKn-DYwtj4fDRMKOmV6SKNU-mXMpVGVYMrZQsg4yL7QuYSKk3vcB6cJyxanJNvo4UqbTVRAOubIEV3j2ZV5iz_7VF-wAKdOymjYo4KTeUbTUUFOew-s__fp-LhX98S6A8Mn8elJC1rJ5kBu9AvjUGdcv6419Q1qjuiZJNgwAV7yuqKHjp9dPL96GLwg1Wn5CmUe3-cjaJTZDB48qWwN4dJGTVmoSetiH0bpnak5kPXgyE1WXrGGvlDsiTpnKGzYGFT_prOflYRgbJilCV9wFh1qL6a0HjXADV4g\",\"protectedHeader\":\"eyJhbGciOiJSUzI1NiIsIkZTUElPUC1VUkkiOiIvdHJhbnNmZXJzL2EzOGY5MjY5LTkyNDktNDY3Yi05NmYzLTQ4YjJlZDcyNjFjYy9lcnJvciIsIkZTUElPUC1IVFRQLU1ldGhvZCI6IlBVVCIsIkZTUElPUC1Tb3VyY2UiOiJzd2l0Y2giLCJGU1BJT1AtRGVzdGluYXRpb24iOiJ0ZXN0aW5ndG9vbGtpdGRmc3AiLCJEYXRlIjoiV2VkLCAxOSBKYW4gMjAyMiAwODozMTozOCBHTVQifQ\"}",
    "tracestate": "mojaloop=eyJzcGFuSWQiOiIzODU5OGI5Nzc5ZjczOTU5In0=",
    "content-length": "79",
    "host": "moja1-ml-testing-toolkit-backend:5000"
  },
  "body": {
    "errorInformation": {
      "errorCode": "3303",
      "errorDescription": "Transfer expired"
    }
  }
}

Running the following SQL query on transferError table returns no results:

select * from transferError where transferId = 'a38f9269-9249-467b-96f3-48b2ed7261cc';

[mdebarros]

Verified this issue using the following GP test on Moja1 --> hub/golden_path/feature_tests/transfer_negative_scenarios/fulfil-reserved-v1.0.json

Callback

{
  "url": "put /transfers/a38f9269-9249-467b-96f3-48b2ed7261cc/error",
  "headers": {
    "content-type": "application/vnd.interoperability.transfers+json;version=1.1",
    "date": "Wed, 19 Jan 2022 08:31:38 GMT",
    "authorization": "{$inputs.TTK_BEARER_TOKEN}",
    "traceparent": "00-aabbdc555b3acee9361afafab3942ed7-38598b9779f73959-30",
    "user-agent": "axios/0.21.4",
    "connection": "keep-alive",
    "fspiop-http-method": "PUT",
    "fspiop-uri": "/transfers/a38f9269-9249-467b-96f3-48b2ed7261cc/error",
    "fspiop-source": "switch",
    "fspiop-destination": "testingtoolkitdfsp",
    "fspiop-signature": "{\"signature\":\"yhZcNwjGi0SxeauL66j9F9YSrKbkgVXgsqrWQKr3cAFfBJp43LEHKn-DYwtj4fDRMKOmV6SKNU-mXMpVGVYMrZQsg4yL7QuYSKk3vcB6cJyxanJNvo4UqbTVRAOubIEV3j2ZV5iz_7VF-wAKdOymjYo4KTeUbTUUFOew-s__fp-LhX98S6A8Mn8elJC1rJ5kBu9AvjUGdcv6419Q1qjuiZJNgwAV7yuqKHjp9dPL96GLwg1Wn5CmUe3-cjaJTZDB48qWwN4dJGTVmoSetiH0bpnak5kPXgyE1WXrGGvlDsiTpnKGzYGFT_prOflYRgbJilCV9wFh1qL6a0HjXADV4g\",\"protectedHeader\":\"eyJhbGciOiJSUzI1NiIsIkZTUElPUC1VUkkiOiIvdHJhbnNmZXJzL2EzOGY5MjY5LTkyNDktNDY3Yi05NmYzLTQ4YjJlZDcyNjFjYy9lcnJvciIsIkZTUElPUC1IVFRQLU1ldGhvZCI6IlBVVCIsIkZTUElPUC1Tb3VyY2UiOiJzd2l0Y2giLCJGU1BJT1AtRGVzdGluYXRpb24iOiJ0ZXN0aW5ndG9vbGtpdGRmc3AiLCJEYXRlIjoiV2VkLCAxOSBKYW4gMjAyMiAwODozMTozOCBHTVQifQ\"}",
    "tracestate": "mojaloop=eyJzcGFuSWQiOiIzODU5OGI5Nzc5ZjczOTU5In0=",
    "content-length": "79",
    "host": "moja1-ml-testing-toolkit-backend:5000"
  },
  "body": {
    "errorInformation": {
      "errorCode": "3303",
      "errorDescription": "Transfer expired"
    }
  }
}

Running the following SQL query on transferError table returns no results:

select * from transferError where transferId = 'a38f9269-9249-467b-96f3-48b2ed7261cc';

@sri-miriyala please verify if these details/findings match the gist of your issue?

[sri-miriyala]

yes.. this is the issue @mdebarros

[elnyry-sam-k]

Hey team! Please add your planning poker estimate with Zenhub @mdebarros @sri-miriyala @vijayg10 @kleyow

[mdebarros]

PR:

• fix(mojaloop/#2644): missing error-code for the transfer in the central-ledger db testing-toolkit-test-cases#105
• fix(mojaloop/#2644): missing error-code for the transfer in the central-ledger db central-ledger#929

[mdebarros]

TTK GP Tests for hub/golden_path/feature_tests/transfer_negative_scenarios/payer_transfer_timeout.json

Tests results from running payer transfer timeout test-case (introduced in mojaloop/testing-toolkit-test-cases#105) test results on Moja4. executed against mojaloop/central-ledger/v16.3.3-snapshot.1:

SQL Query for Transfer and TransfersError tables for transferId = a65c2a7b-578b-4bb0-88e7-2b2784a57f32

select * from transfer as tx
inner join transferError as txe on tx.transferId = txe.transferId 
where tx.transferId = 'a65c2a7b-578b-4bb0-88e7-2b2784a57f32';

Finance Portal showing errorCode

Finance Portal detailed information showing Error Code for [mojaloop/central-ledger/v16.3.3-snapshot.1](mojaloop/central-ledger/v16.3.3-snapshot.1

Same screen showing the result when using previous mojaloop/central-ledger:v16.3.1 without fix