-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Github report should be sorted on release version #48
Comments
First upgrade to 2.12.1 of maven-changes-plugin second adding configuration like this: <configuration>
<githubAPIServerId>github</githubAPIServerId>
<githubAPIScheme>https</githubAPIScheme>
<includeOpenIssues>false</includeOpenIssues>
<onlyMilestoneIssues>true</onlyMilestoneIssues>
<runOnlyAtExecutionRoot>true</runOnlyAtExecutionRoot>
<onlyCurrentVersion>false</onlyCurrentVersion>
</configuration> If you like to use it locally you have to create a personal access token and configuring that in the settings.xml file instead of the password. |
The disadvantage of this is: Making a release requires an access token in your github account as well as the configuration in |
Currently I'm thinking about removing the whole github page and make the release notes available via https://github.com/mojohaus/mojo-parent/releases (more more detailed like this https://github.com/khmarbaise/maven-it-extension/releases) or maybe even better via https://github.com/marketplace/actions/release-drafter in a more automated way. |
IMO we shouldn't forget that Maven plugins are focused around their maven site. If we have the release notes in github we should at least have a link there from the site. |
This is fine for me. +1 |
So after testing some parts the release drafter is not the correct one cause it only uses pull request which is not enough for us. The following is the result using a github-release-notes-generator (from my own command line; I'm trying to get a way to get that running automatically while a milestone is closed). But I think the content looks ok: (Attention those release notes are from versions-maven-plugin repo and not from mojo-parent): Using the following configuration: sections:
- title: "Bug Fixes"
emoji: "🐞"
labels: ["bug"]
- title: "Enhancements"
emoji: "⭐"
labels: ["enhancement"]
- title: "Dependency Upgrades"
emoji: "🔨"
labels: ["dependency-upgrade"]
- title: "Documentation"
emoji: "📔"
labels: ["documentation"] 🐞 Bug Fixes
⭐ Enhancements
🔨 Dependency Upgrades
❤️ ContributorsWe'd like to thank all the contributors who worked on this release! |
@khmarbaise So the release notes would then be in Github? And we would have a link from the mojo site? The L&F is ok with me. |
Yes the resulting release notes would be put into the release pages on GitHub (#113) and a link in the generated site of the released state as well. |
I am all for this. Looking for release-info directly on GitHub is what people are used to nowadays. |
Currently (mojo-parent 40) the Github report is sorted on issue number, which makes it hard to see what has been fixed in what release. Change that so it is sorted on release version.
The text was updated successfully, but these errors were encountered: