Skip to content

Fix mobile navbar depths (z-indexes) #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 24, 2022
Merged

Fix mobile navbar depths (z-indexes) #26

merged 3 commits into from
Jan 24, 2022

Conversation

aloysb
Copy link

@aloysb aloysb commented Jan 21, 2022

Summary

Solve the following issues with the navbar:

  • Impossible to click links on mobile sidebar: side mask would overlay on top of the whole app; if you clicked/touch anywhere on the screen it would hit .sidebar-mask and toggle the sidebar off.
  • Z-index issues on the sidebar, navbar and video player controls: the video player controls was displayed on top of the sidebar/navbar (had a z-index of 100)

Previously

Screen Shot 2022-01-22 at 07 24 50

Now

Screen Shot 2022-01-22 at 07 23 54

Screen Shot 2022-01-22 at 07 23 50

@aloysb aloysb mentioned this pull request Jan 21, 2022
Closed
@xavierfoucrier xavierfoucrier self-assigned this Jan 24, 2022
@xavierfoucrier xavierfoucrier added the bug bug to fix label Jan 24, 2022
@xavierfoucrier xavierfoucrier merged commit a3f9b2c into mojs:source Jan 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@xavierfoucrier xavierfoucrier

Labels
bug bug to fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aloysb @xavierfoucrier