chore: improve resource exhausted error message #485
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
malandis
reviewed
Nov 4, 2024
Contributor
malandis
left a comment
malandis
left a comment
There was a problem hiding this comment.
Few suggestions for improvement/maintenance.
malandis
reviewed
Nov 8, 2024
Contributor
malandis
left a comment
malandis
left a comment
There was a problem hiding this comment.
Very clean! Just one more change for completeness.
malandis
approved these changes
Nov 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes https://github.com/momentohq/dev-eco-issue-tracker/issues/1041
errmetadata in order to report the cause in the message wrapper. If the metadata is not available, we try to use string matching on the error details.RpcErrors for each RPC call across the various clients. Otherwise,errmetadata is not available for parsing.