chore: specify path to release-please manifest #487
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anitarua
changed the title
malandis
reviewed
Nov 12, 2024
Contributor
malandis
left a comment
malandis
left a comment
There was a problem hiding this comment.
Looks like we'll have to dig in further. We can sync about it.
malandis
approved these changes
Nov 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #486 -- release-please still did not produce a new PR to cut a new release.
I think switching the release-please github actions version tov3to match what the other SDKs use will allow thechangelog-typesfield to be picked up and parse our commits correctly.Update: usingv4shouldn't be a problem. I think we're just missing the argument to specify the path to the manifest, as shown in their example.Found an issue in the release-please action that seems to show the same problem (action ends with "No user facing commits found since ... - skipping"), and the solution was to move all the configs into the manifest. Our file still had
release-typeas part of the github action yaml block.