Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unusual inference arising from is-a overloading from ORDO #324

Closed
cmungall opened this issue Aug 20, 2018 · 6 comments
Closed

Unusual inference arising from is-a overloading from ORDO #324

cmungall opened this issue Aug 20, 2018 · 6 comments
Assignees
Labels
effort-L Ticket should take 2 hours or less to complete high priority obsolete This includes both obsolete and merge requests ordo-project

Comments

@cmungall
Copy link
Member

cmungall commented Aug 20, 2018

E.g.

image

FIX: remove assertion 46,XY complete gonadal dysgenesis is a syndromic lymphedema

@cmungall
Copy link
Member Author

cmungall commented Aug 20, 2018

image

FIX: syndrome associated with X should have X as a feature rather than subtype of X

@nicolevasilevsky
Copy link
Member

related to #834

@nicolevasilevsky
Copy link
Member

nicolevasilevsky commented Feb 17, 2021

to do:

  • syndrome associated with X should have X as a feature rather than subtype of X

@nicolevasilevsky nicolevasilevsky added this to Highest priority in Curation Feb 17, 2021
@nicolevasilevsky nicolevasilevsky moved this from Highest priority to To do in Curation Apr 29, 2021
@nicolevasilevsky nicolevasilevsky added the effort-S Ticket should take 30 min or less to complete label May 6, 2021
@nicolevasilevsky
Copy link
Member

nicolevasilevsky commented Jul 30, 2021

Action items:

  • For the classes below, if the parent class is the "with", it should be excluded (see instructions here)
  • If there is not an additional parent, add the superclass 'syndromic disease', source: your https://orcid.org/0000-0002-6601-2165
  • add seeAlso to this ticket

each curator should check and box and open a new ticket for each disease branch that they work on

These terms below are candidates for obsoletion

@nicolevasilevsky nicolevasilevsky added effort-M Ticket should take 1 hour or less to complete effort-L Ticket should take 2 hours or less to complete and removed effort-S Ticket should take 30 min or less to complete effort-M Ticket should take 1 hour or less to complete labels Jul 30, 2021
@nicolevasilevsky nicolevasilevsky removed their assignment Jul 30, 2021
nicolevasilevsky added a commit that referenced this issue Aug 10, 2021
and fix definitions

address #324
@nicolevasilevsky
Copy link
Member

nicolevasilevsky commented Aug 20, 2021

  • we want to obsolete these grouping classes
  • first check the usage of these terms in Monarch
  • do not need to add the phenotype annotations

@nicolevasilevsky
Copy link
Member

'myalgia-eosinophilia syndrome associated with tryptophan' has 10 phenotypes in Monarch, do not obsolete
https://monarchinitiative.org/disease/MONDO:0016822#phenotype

nicolevasilevsky added a commit that referenced this issue Aug 20, 2021
@nicolevasilevsky nicolevasilevsky added this to the October release milestone Aug 20, 2021
@nicolevasilevsky nicolevasilevsky removed this from To do in Curation Aug 20, 2021
@nicolevasilevsky nicolevasilevsky added obsolete This includes both obsolete and merge requests and removed Ordo-xref labels Aug 20, 2021
nicolevasilevsky added a commit that referenced this issue Sep 28, 2021
@nicolevasilevsky nicolevasilevsky moved this from To do to Done in ORDO obsoletion work Oct 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
effort-L Ticket should take 2 hours or less to complete high priority obsolete This includes both obsolete and merge requests ordo-project
Development

No branches or pull requests

3 participants