Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ROBOT template based obsoletion #3737

Merged
merged 12 commits into from
Oct 14, 2021
Merged

ROBOT template based obsoletion #3737

merged 12 commits into from
Oct 14, 2021

Conversation

matentzn
Copy link
Member

@matentzn matentzn commented Sep 30, 2021

property_value: seeAlso https://github.com/monarch-initiative/mondo/issues/324 xsd:string
name: obsolete Pierre Robin syndrome associated with collagen disease
relationship: seeAlso https://github.com/monarch-initiative/mondo/issues/324
property_value: IAO:0000231 "out of scope"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't open the file in Protege.
I think this needs to be:
property_value: IAO:0000231 "out of scope" xsd:string

@matentzn matentzn marked this pull request as ready for review October 7, 2021 18:20
@matentzn
Copy link
Member Author

matentzn commented Oct 7, 2021

There is a problem here with robot remove.. I can either tell it to fix the class hierarchy (i.e if A sub B sub C, you delete B, then add A sub C) or I can tell it not to do it (which means A becomes a floater and needs to be classified manually. The problem is, if I tell it to fix the class hierarchy, it will fix all of it. Which means it will try to fix a million subclass relations that we did not tell it to :( Shit

@matentzn matentzn marked this pull request as draft October 7, 2021 18:26
@nicolevasilevsky
Copy link
Member

Oh dear.
It's not the end of the world if this workflow doesn't work out, I can always obsolete these classes one at a time.

@matentzn
Copy link
Member Author

@nicolevasilevsky Put one more time on our agenda, have an idea how to fix this with SPARQL

@nicolevasilevsky nicolevasilevsky marked this pull request as ready for review October 14, 2021 16:56
@nicolevasilevsky
Copy link
Member

to do:
check in protege
once passes, merge
after
create new PR with this command
sh run.sh make make related_to_exact_where_label

and add parents to orphans
@nicolevasilevsky
Copy link
Member

@matentzn

These terms were missing owl:depracated true. I fixed it manually.

Some terms were left orphaned because the terms that were obsoleted were children of 'disease or disorder'. I added parents to those terms. This won't happen very often.

@nicolevasilevsky nicolevasilevsky merged commit 9963dde into master Oct 14, 2021
@nicolevasilevsky nicolevasilevsky deleted the obsolete-robot branch October 14, 2021 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Obsolete] 'systemic disease'
2 participants