This repository was archived by the owner on May 17, 2021. It is now read-only.
UX improvements: display doc count, do not display line numbers #20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lrlna
changed the title
Merged
imlucas
added a commit
that referenced
this pull request
Dec 4, 2019
Cutting master so all of your export improvements from the past few days can be upstreamed into compass asap with @mongodb-js/compass-import-export@^4.2.0. The import type casting stuff in #18 is complex enough that I don't want it blocking so it will go as 5.0.0. We can keep this 4.x-releases branch ref around just in case casting performance is a real dud and we want to take another stab at it. Now that this release has been published, a PR to mongodb-js/compass 📦 @mongodb-js/compass-import-export@^4.2.0 has changelog: UX improvements: display doc count, do not display line numbers #20 COMPASS-3961: allow adding missing fields #19 COMPASS-3851: ability to add fields when exporting collection #17
imlucas
added a commit
to mongodb-js/compass
that referenced
this pull request
Dec 6, 2019
Now that this release has been published, a PR to mongodb-js/compass 📦 `@mongodb-js/compass-import-export@^4.2.0` has changelog: - UX improvements: display doc count, do not display line numbers mongodb-js/compass-import-export#20 - Closes COMPASS-3961: allow adding missing fields mongodb-js/compass-import-export#19 - Closes COMPASS-3851: ability to add fields when exporting collection mongodb-js/compass-import-export#17
3 tasks
imlucas
added a commit
to mongodb-js/compass
that referenced
this pull request
Dec 6, 2019
) Now that this release has been published, a PR to mongodb-js/compass 📦 `@mongodb-js/compass-import-export@^4.2.0` has changelog: - UX improvements: display doc count, do not display line numbers mongodb-js/compass-import-export#20 - Closes COMPASS-3961: allow adding missing fields mongodb-js/compass-import-export#19 - Closes COMPASS-3851: ability to add fields when exporting collection mongodb-js/compass-import-export#17
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Displays document count, does not display line numbers in editor, removes editor 80 character gutter line.
Checklist
New tests and/or benchmarks are includedDocumentation is changed or addedMotivation and Context
Currently when opening up the export modal, you don't get to see the current document count with the initial query. It's displayed as
null. This PR includes a document count on open, and populates that number.Some folks were confused that the editor in export modal is not editable, so I am removing the lines to hopefully indicate that a bit more.
Also, for aesthetic purposes, removing the gutter line for the editor.
Types of changes