This repository was archived by the owner on May 17, 2021. It is now read-only.
COMPASS-3961: allow adding missing fields #19
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imlucas
approved these changes
Nov 26, 2019
There was a problem hiding this comment.
Currently once I hit enter to save the currently edited field, I am not able to prevent the modal from scrolling up a bit. This happens because the element is rerendering, so I understand that the state just changed and the focus was lost. Anyone have an idea as to how to get the focus back to the previous state, aka the input field at the bottom after the rerender?
You could track in state if any fields have been customized and if so focus to the input field on re-render?
|
@imlucas, oh my god, ofc that makes sense. Thankssss! |
Merged
imlucas
added a commit
that referenced
this pull request
Dec 4, 2019
Cutting master so all of your export improvements from the past few days can be upstreamed into compass asap with @mongodb-js/compass-import-export@^4.2.0. The import type casting stuff in #18 is complex enough that I don't want it blocking so it will go as 5.0.0. We can keep this 4.x-releases branch ref around just in case casting performance is a real dud and we want to take another stab at it. Now that this release has been published, a PR to mongodb-js/compass 📦 @mongodb-js/compass-import-export@^4.2.0 has changelog: UX improvements: display doc count, do not display line numbers #20 COMPASS-3961: allow adding missing fields #19 COMPASS-3851: ability to add fields when exporting collection #17
imlucas
added a commit
to mongodb-js/compass
that referenced
this pull request
Dec 6, 2019
Now that this release has been published, a PR to mongodb-js/compass 📦 `@mongodb-js/compass-import-export@^4.2.0` has changelog: - UX improvements: display doc count, do not display line numbers mongodb-js/compass-import-export#20 - Closes COMPASS-3961: allow adding missing fields mongodb-js/compass-import-export#19 - Closes COMPASS-3851: ability to add fields when exporting collection mongodb-js/compass-import-export#17
3 tasks
imlucas
added a commit
to mongodb-js/compass
that referenced
this pull request
Dec 6, 2019
) Now that this release has been published, a PR to mongodb-js/compass 📦 `@mongodb-js/compass-import-export@^4.2.0` has changelog: - UX improvements: display doc count, do not display line numbers mongodb-js/compass-import-export#20 - Closes COMPASS-3961: allow adding missing fields mongodb-js/compass-import-export#19 - Closes COMPASS-3851: ability to add fields when exporting collection mongodb-js/compass-import-export#17
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a
+ ADD FIELDbutton with an input field in export-fields modal.Motivation and Context
+ ADD FIELDbutton scrolls over to the bottom of the table and focuses on the input field to be edited. The field is only saved onenter, which is indicated by the text on the side of the table. When the input field is submitted,fieldsprops are updated and the component is refreshed. That particular field is saved even after the user goes toOUTPUTand comes back toFIELDS.Open Questions
Currently once I hit enter to save the currently edited field, I am not able to prevent the modal from scrolling up a bit. This happens because the element is rerendering, so I understand that the state just changed and the focus was lost. Anyone have an idea as to how to get the focus back to the previous state, aka the input field at the bottom after the rerender?
Types of changes