This repository was archived by the owner on May 17, 2021. It is now read-only.
fix: Check if dataService is connected before trying to refresh indexes COMPASS-4741 #162
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gribnoysup
changed the title
5 tasks
mcasimir
deleted the
compass-4741-check-if-connected-before-fetching-indexes
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an intermediate workaround for a leaky compass plugins issue. We don't expect
dataServiceto be disconnected when these actions are dispatched ever, so technically throwing in this case might've been a right thing to do, but currently as a workaround for leaking listeners ofrefresh-dataevent, we just warn and no-op ifdataServiceis disconnected