COMPASS-1679 Reorder data-service setup to avoid instance refresh

[pzrq]

The net effect of this PR is to remove the following, by reordering the data-service and Compass setup so the data-service setup now comes first:

return client 
        .clickInstanceRefreshIcon()
        .waitForInstanceRefresh()

It should have at least 20 Travis runs to validate it has fixed this 35% of the time issue, so I will be pushing noop commits to the branch to get those Travis runs.

[durran]

LGTM

[pzrq]

For info (somehow did not click submit yesterday), build failures from the 20 runs after suggest this resolved the issue:

  1) #schema when applying a filter in the schema tab checks the collections table:
     Error: Timeout of 60000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves.
  
  2) #schema when applying a filter in the schema tab applies the filter again while on schema tab:
     Error: Timeout of 60000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves.
  
  3) #schema "after all" hook:
     Error: Timeout of 60000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves.

https://travis-ci.com/10gen/compass/jobs/85813876

  1) App Menu "before all" hook:
     Error: Timeout of 2000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves.

https://travis-ci.com/10gen/compass/jobs/85814519

  1) #explain "before all" hook:
     Error: Timeout of 60000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves.
  
  2) #explain "after all" hook:
     TypeError: Cannot read property 'quit' of null
      at quitCompass (test/functional/support/spectron-support.js:73:13)
      at Context.<anonymous> (test/functional/explain.test.js:26:12)
  3) #indexes "before all" hook:
     Error: Timeout of 60000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves.
  
  4) #indexes "after all" hook:
     TypeError: Cannot read property 'quit' of null
      at quitCompass (test/functional/support/spectron-support.js:73:13)
      at Context.<anonymous> (test/functional/indexes.test.js:27:12)
  5) #query-bar "before all" hook:
     Error: Timeout of 60000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves.
  
  6) #query-bar "after all" hook:
     TypeError: Cannot read property 'quit' of null
      at quitCompass (test/functional/support/spectron-support.js:73:13)
      at Context.<anonymous> (test/functional/query-bar.test.js:29:12)
  7) #schema "before all" hook:
     Error: Timeout of 60000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves.
  
  8) #schema "after all" hook:
     TypeError: Cannot read property 'quit' of null
      at quitCompass (test/functional/support/spectron-support.js:73:13)
      at Context.<anonymous> (test/functional/schema.test.js:26:12)
  9) #sidebar "before all" hook:
     Error: Timeout of 60000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves.
  
  10) #sidebar "after all" hook:
     TypeError: Cannot read property 'quit' of null
      at quitCompass (test/functional/support/spectron-support.js:73:13)
      at Context.<anonymous> (test/functional/sidebar.test.js:26:12)

https://travis-ci.com/10gen/compass/jobs/85814521

[pzrq]

Thanks @durran 👍