INT-741 🎉 persisting last known version to localstorage #188
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is for future updates that want to know what version the user has used before. E.g. feature tour only shows new features, internal data structure schemas might change and need migration, etc.
src/home/index.js
Outdated
There was a problem hiding this comment.
Would "localStorage.lastKnownVersion !== app.meta['App Version']" cover the case of "_.isUndefined(localStorage.lastKnownVersion)" as well or is there a case I'm not seeing?
There was a problem hiding this comment.
Good point. app.meta['App Version'] should always be defined. So this can be simplified to
if (localStorage.lastKnownVersion !== app.meta['App Version']) {Will patch.
|
LGTM. 🚢 |
WaleyChen
pushed a commit
that referenced
this pull request
Nov 5, 2015
INT-741 🎉 persisting last known version to localstorage
gribnoysup
pushed a commit
that referenced
this pull request
Apr 26, 2021
Bumps [electron](https://github.com/electron/electron) from 7.1.10 to 7.1.11. - [Release notes](https://github.com/electron/electron/releases) - [Changelog](https://github.com/electron/electron/blob/master/docs/breaking-changes.md) - [Commits](electron/electron@v7.1.10...v7.1.11) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is for future updates that want to know what version the user has used before.
E.g. feature tour only shows new features, internal data structure schemas might change and need migration, etc.