Skip to content

INT-741 🎉 persisting last known version to localstorage #188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 5, 2015
Merged

INT-741 🎉 persisting last known version to localstorage #188

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cac8434
INT-741 :tada: persisting last known version to localstorage
rueckstiess Nov 5, 2015
6eb68bf
INT-741 :tada: persisting last known version to localstorage patch
WaleyChen Nov 5, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion src/app.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -259,7 +259,6 @@ app.extend({
*
* @param {String} id - A key in `FEATURES`.
* @param {Boolean} bool - whether to enable (true) or disable (false)
* @return {Boolean}
*/
setFeature: function(id, bool) {
FEATURES[id] = bool;
Expand Down
5 changes: 2 additions & 3 deletions src/home/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
var _ = require('lodash');
var View = require('ampersand-view');
var format = require('util').format;
var SidebarView = require('../sidebar');
Expand Down Expand Up @@ -51,9 +50,9 @@ var HomeView = View.extend({
},
render: function() {
this.renderWithTemplate(this);
if (_.isUndefined(localStorage.tourHasRun)) {
if (localStorage.lastKnownVersion !== app.meta['App Version']) {
this.renderSubview(new TourView(), this.queryByHook('tour-container'));
localStorage.tourHasRun = 'true';
localStorage.lastKnownVersion = app.meta['App Version'];
}
},
onInstanceFetched: function() {
Expand Down