Skip to content

Conversation

imlucas
Copy link
Contributor

@imlucas imlucas commented May 12, 2015

Just wondering if this is helpful at all. Spelling and grammar checks pending.

cc @kangas @rueckstiess

@rueckstiess
Copy link
Contributor

Yes, helpful! Bit of feedback:

Starts off really well, lots of comments in the first part, very understandable.

lets write some views

This part is just a huge piece of code without comments, hard to understand what's going on for newbies

Finally, modify the template scout/scout-ui/src/home/index.jade

Here I was confused if you meant "replace the file" or how to modify it, because it doesn't look at all like the existing file. Needs instructions where exactly to modify and if this is just adding or changing lines.

Also, a paragraph at the beginning what the scope of the tutorial is would be useful. "We're going to add a document view to the side...".

@rueckstiess
Copy link
Contributor

Generally, what I found confusing is what each of the views are, i,e. collection, collection-list-item, field-list, field-list-item, type-list, type-list-item... Something like below image, but adopted to file names and view names would be helpful.

prototype_anatomy

@imlucas
Copy link
Contributor Author

imlucas commented Jun 16, 2015

@rueckstiess thx! imo, this ended up being just too gigantic to make sense in a blog post so going to nuke this PR.

Moved your comment above to doc improvements PR #40

@imlucas imlucas closed this Jun 16, 2015
@imlucas imlucas deleted the docs-schema-stream branch July 6, 2015 21:33
pzrq added a commit that referenced this pull request Dec 23, 2016
# This is the 1st commit message:

Add redhat_config category of Applications/Databases

https://fedoraproject.org/wiki/RPMGroups

e.g. Some DB GUIs present are there so it seems logical we might wish to be too, in the long run:
https://rpmfind.net/linux/RPM/Applications_Databases.html

# This is the commit message #2:

Drop category, add categories

So confusing!
1. Category ~= Group, approximately, which is deprecated in Fedora 17:
https://fedoraproject.org/wiki/How_to_create_an_RPM_package#Creating_a_SPEC_file

2. Setting ‘categories’ to “Development” seems to be the most appropriate for now:
https://specifications.freedesktop.org/menu-spec/latest/apa.html#main-category-registry
https://github.com/unindented/electron-installer-redhat#optionscategories
pzrq pushed a commit that referenced this pull request Feb 20, 2017
* Change delete index button to red

* Fixed Times New Roman button issue

* Removed blue outline on focused button states, removed blue outline from dropdown selection as well

* Remove subtle blue outline from disabled buttons on both default and hover state

* Remove bootstrap button.less and button-groups.less dependencies

* Remove blue outline from focusing on filter and advanced query bar option

* Fixed line-height issue to make sure all buttons are vertically centered

* Fix line-height issue for validation page

* Got rid of blue selector on all buttons, not just btn class

* Fixed some vertical alignment issues in validation tab

* Deleting 10strap
gribnoysup pushed a commit that referenced this pull request Apr 26, 2021
…tages

INT 1658 type error execution stages
gribnoysup pushed a commit that referenced this pull request Apr 26, 2021
INT-430: added boolean flag for enterprise_module present/absent.
gribnoysup pushed a commit that referenced this pull request Apr 26, 2021
📝 added ideas for metrics in Compass. All work in progress.
gribnoysup pushed a commit that referenced this pull request Apr 26, 2021
gribnoysup pushed a commit that referenced this pull request Apr 26, 2021
Update travis.yml: Add node 6 & 7
gribnoysup pushed a commit that referenced this pull request Apr 26, 2021
added getResourcesWithActions() helper
gribnoysup pushed a commit that referenced this pull request Apr 26, 2021
move utils to its own file and added shouldStoreUpdate method.
gribnoysup pushed a commit that referenced this pull request Apr 26, 2021
Added pre-publish/test/start compile scripts
kraenhansen added a commit that referenced this pull request Dec 20, 2024
* Clean up components, using flex gap

* Fix type warnings for onClick handlers

* Clean up "Actions" generic types

* Drive-by removal of a comment

* Remove unneeded memoization
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants