-
Notifications
You must be signed in to change notification settings - Fork 234
wip(docs): First crack at schema + streams post #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Yes, helpful! Bit of feedback: Starts off really well, lots of comments in the first part, very understandable.
This part is just a huge piece of code without comments, hard to understand what's going on for newbies
Here I was confused if you meant "replace the file" or how to modify it, because it doesn't look at all like the existing file. Needs instructions where exactly to modify and if this is just adding or changing lines. Also, a paragraph at the beginning what the scope of the tutorial is would be useful. "We're going to add a document view to the side...". |
@rueckstiess thx! imo, this ended up being just too gigantic to make sense in a blog post so going to nuke this PR. Moved your comment above to doc improvements PR #40 |
# This is the 1st commit message: Add redhat_config category of Applications/Databases https://fedoraproject.org/wiki/RPMGroups e.g. Some DB GUIs present are there so it seems logical we might wish to be too, in the long run: https://rpmfind.net/linux/RPM/Applications_Databases.html # This is the commit message #2: Drop category, add categories So confusing! 1. Category ~= Group, approximately, which is deprecated in Fedora 17: https://fedoraproject.org/wiki/How_to_create_an_RPM_package#Creating_a_SPEC_file 2. Setting ‘categories’ to “Development” seems to be the most appropriate for now: https://specifications.freedesktop.org/menu-spec/latest/apa.html#main-category-registry https://github.com/unindented/electron-installer-redhat#optionscategories
* Change delete index button to red * Fixed Times New Roman button issue * Removed blue outline on focused button states, removed blue outline from dropdown selection as well * Remove subtle blue outline from disabled buttons on both default and hover state * Remove bootstrap button.less and button-groups.less dependencies * Remove blue outline from focusing on filter and advanced query bar option * Fixed line-height issue to make sure all buttons are vertically centered * Fix line-height issue for validation page * Got rid of blue selector on all buttons, not just btn class * Fixed some vertical alignment issues in validation tab * Deleting 10strap
…tages INT 1658 type error execution stages
INT-430: added boolean flag for enterprise_module present/absent.
📝 added ideas for metrics in Compass. All work in progress.
INT-743 fix for ampersand-state@4.8.0
Update travis.yml: Add node 6 & 7
added getResourcesWithActions() helper
move utils to its own file and added shouldStoreUpdate method.
Added pre-publish/test/start compile scripts
* Clean up components, using flex gap * Fix type warnings for onClick handlers * Clean up "Actions" generic types * Drive-by removal of a comment * Remove unneeded memoization
Just wondering if this is helpful at all. Spelling and grammar checks pending.
cc @kangas @rueckstiess