fix(hadron-build): Do not sign deb installers #2232
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Seems like it didn't work before and breaking installer now so we are disabling it for now
addaleax
approved these changes
Jun 9, 2021
mcasimir
reviewed
Jun 9, 2021
| debug('creating deb...', this.installerOptions.deb); | ||
| return createDeb(this.installerOptions.deb).then(() => { | ||
| return sign(this.dest(this.linux_deb_filename)); | ||
| // We do not sign debs because it doesn't work, see |
There was a problem hiding this comment.
I think we can delete this comment, the slack thread is going to be deleted in 30 days
There was a problem hiding this comment.
Oh, I thought it's only images that are deleted in 30 days... okay, will clean it up
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seems like it didn't work before and breaking installer now so we are disabling it for now. See this Slack thread for more context