Skip to content

fix(hadron-build): Do not sign deb installers #2232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 9, 2021
Merged

fix(hadron-build): Do not sign deb installers #2232

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion packages/hadron-build/lib/target.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -680,7 +680,12 @@ class Target {
const createDeb = require('electron-installer-debian');
debug('creating deb...', this.installerOptions.deb);
return createDeb(this.installerOptions.deb).then(() => {
return sign(this.dest(this.linux_deb_filename));
// We do not sign debs because it doesn't work, see
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can delete this comment, the slack thread is going to be deleted in 30 days

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I thought it's only images that are deleted in 30 days... okay, will clean it up

// this thread for context:
// https://mongodb.slack.com/archives/G2L10JAV7/p1623169331107600
//
// return sign(this.dest(this.linux_deb_filename));
return this.dest(this.linux_deb_filename);
});
});
};
Expand Down