fix(ci): Switch compilation scripts in packages from prepare to prepublishOnly #2356
Conversation
…blishOnly npm >= 7.20 started to run install lifecycle scripts automatically in workspace subpackages and it is doing it without taking the topology of the packages in account. This causes install/ci to fail because subpackages are trying to bootstrap themselves out of order and fail because their workspace dependencies are not ready yet. This patch switches all prepare scripts to prepublishOnly so that npm does not run them on install, but they are still activated when running publish with lerna.
gribnoysup
force-pushed
the
fix-npm-7-topology-issue
branch
from
495e66b to
51b7016
Compare
package.json
Outdated
| "scripts": { | ||
| "bootstrap": "npm install && lerna run prepare --stream", | ||
| "bootstrap-evergreen": "npm ci && lerna run prepare", | ||
| "bootstrap": "npm install && lerna run prepublishOnly --stream", |
There was a problem hiding this comment.
Would it be possible to be less implicit here and really just add a bootstrap task to all the packages with that being what we would expect to be called as part of the bootstrap?
I feel it would be better to avoid overloading prepublishOnly, like that we would probably avoid having unrelated tasks being run incidentally in future.
For example we could have probably avoided re-downloading the fonts in the plugins on prepublishOnly since those are only used in development (probably) .. but well I hope it makes sense anyway.
There was a problem hiding this comment.
Yeah, let's split them up. prepare that was used there before was also running on install and before publish, so this PR just doesn't change the behavior, but your suggestion makes a lot of sense
There was a problem hiding this comment.
Done in 7c071d7, wanna give the PR another look?
|
Tests are green and bootstrap and prepublish are separated, merging |
2 participants
npm >= 7.20 started to run install lifecycle scripts automatically in workspace
subpackages and it is doing it without taking the topology of the packages in
account. This causes install/ci to fail because subpackages are trying to bootstrap
themselves out of order and fail because their workspace dependencies are not ready
yet. This patch switches all prepare scripts to prepublishOnly so that npm does not
run them on install, but they are still activated when running publish with lerna.