Skip to content

fix(ci): Switch compilation scripts in packages from prepare to prepublishOnly #2356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 21, 2021
Merged

fix(ci): Switch compilation scripts in packages from prepare to prepublishOnly #2356

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
51b7016
fix(ci): Switch compilation scripts in packages from prepare to prepu…
gribnoysup Jul 16, 2021
7c071d7
chore: Split bootstrap and prepublishOnly into two separate commands
gribnoysup Jul 21, 2021
1b894f5
chore: Change prepublishOnly to bootstrap in CI configs
gribnoysup Jul 21, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .evergreen.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,7 @@ functions:
npm config ls -l
echo "(if npm fails, debug.log will be uploaded to S3)"

# Run npm ci in all the packages
# Install dependencies and prepare all subpackages
npm run bootstrap-evergreen --unsafe-perm -- --stream

# Make sure that cache is populated when other packages are pulling the font
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/build.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,9 +86,9 @@ jobs:
--force-publish "*" \
--yes

# We will run prepare manually to isolate the flakiest part of the
# We will run `bootstrap` manually to isolate the flakiest part of the
# process which is publishing
npx lerna run prepare --stream
npx lerna run bootstrap --stream

# Publish process seems to be pretty flaky on Windows so we are
# retrying it up to 5 times before bailing
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/check-test.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ jobs:
# Dependencies are included when installing as npm workspaces will
# hoist every package in the repo and it's important that the
# dependencies of packages we are planning to test are also prepared
npx lerna run prepare --stream --since $MAIN_BRANCH_NAME --include-dependencies
npx lerna run bootstrap --stream --since $MAIN_BRANCH_NAME --include-dependencies
shell: bash

- name: Run Checks
Expand Down
59 changes: 30 additions & 29 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 3 additions & 3 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,8 @@
"shortcutFolderName": "MongoDB",
"license": "SSPL",
"scripts": {
"bootstrap": "npm install && lerna run prepare --stream",
"bootstrap-evergreen": "npm ci && lerna run prepare",
"bootstrap": "npm install && lerna run bootstrap --stream",
"bootstrap-evergreen": "npm ci && lerna run bootstrap",
"precheck": "npm run depcheck",
"check": "lerna run check --stream",
"check-changed": "npm run check -- --since origin/HEAD --exclude-dependents",
Expand All @@ -33,7 +33,7 @@
"test-changed": "lerna run test --stream --concurrency 1 --since origin/HEAD",
"test-ci": "lerna run test-ci --concurrency 1",
"pretest-packages-publish": "./scripts/monorepo/start-proxy-registry.sh && wait-on -t 3000 http://localhost:4873 && npm-cli-adduser -u test -p test -e test@test.test --registry http://localhost:4873 && echo $'\\n\\n!!! LOCAL REGISTRY DOCKER IMAGE IS RUNNING, DO NOT FORGET TO CLEAN IN UP WHEN YOU ARE DONE\\n\\n'",
"test-packages-publish": "npm run packages-publish -- --registry http://localhost:4873",
"test-packages-publish": "lerna publish from-package --registry http://localhost:4873",
"test-packages-version": "lerna version --no-push --no-private -m \"tmp(release): Test release\"",
"update-akzidenz-cache": "node scripts/download-akzidenz.js --update-cache",
"update-authors": "node scripts/generate-authors.js",
Expand Down
5 changes: 3 additions & 2 deletions packages/compass-aggregations/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,10 +20,11 @@
"check": "npm run lint && npm run depcheck",
"preanalyze": "mkdir -p .ghpages && cross-env NODE_ENV=production webpack --profile --json --config ./config/webpack.prod.config.js > .ghpages/stats.json",
"analyze": "webpack-bundle-analyzer .ghpages/stats.json --no-open --report .ghpages/report.html --mode static --bundleDir lib",
"prepare": "node ../../scripts/download-akzidenz.js && npm run compile",
"prepublishOnly": "npm run compile",
"lint": "eslint \"./src/**/*.{js,jsx}\" \"./test/**/*.js\" \"./electron/**/*.js\" \"./config/**/*.{js,jsx}\"",
"depcheck": "depcheck",
"test-ci": "npm run test"
"test-ci": "npm run test",
"bootstrap": "node ../../scripts/download-akzidenz.js && npm run compile"
},
"license": "SSPL",
"peerDependencies": {
Expand Down
5 changes: 3 additions & 2 deletions packages/compass-app-stores/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,10 +17,11 @@
"cover": "nyc npm run test",
"test-check-ci": "npm run cover && npm run test:karma && npm run compile && npm run check",
"check": "npm run lint && npm run depcheck",
"prepare": "node ../../scripts/download-akzidenz.js && npm run compile",
"prepublishOnly": "npm run compile",
"lint": "eslint \"./src/**/*.{js,jsx}\" \"./test/**/*.js\" \"./electron/**/*.js\" \"./config/**/*.{js,jsx}\"",
"depcheck": "depcheck",
"test-ci": "npm run test"
"test-ci": "npm run test",
"bootstrap": "node ../../scripts/download-akzidenz.js && npm run compile"
},
"license": "SSPL",
"peerDependencies": {
Expand Down
5 changes: 3 additions & 2 deletions packages/compass-auto-updates/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,10 +17,11 @@
"cover": "nyc npm run test",
"test-check-ci": "npm run cover && npm run test:karma && npm run compile && npm run check",
"check": "npm run lint && npm run depcheck",
"prepare": "node ../../scripts/download-akzidenz.js && npm run compile",
"prepublishOnly": "npm run compile",
"lint": "eslint \"./src/**/*.{js,jsx}\" \"./test/**/*.js\" \"./electron/**/*.js\" \"./config/**/*.{js,jsx}\"",
"depcheck": "depcheck",
"test-ci": "npm run test"
"test-ci": "npm run test",
"bootstrap": "node ../../scripts/download-akzidenz.js && npm run compile"
},
"license": "SSPL",
"peerDependencies": {
Expand Down
5 changes: 3 additions & 2 deletions packages/compass-collection-stats/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,10 +22,11 @@
"cover": "nyc npm run test",
"test-check-ci": "npm run cover && npm run test:karma && npm run compile && npm run check",
"check": "npm run lint && npm run depcheck",
"prepare": "node ../../scripts/download-akzidenz.js && npm run compile",
"prepublishOnly": "npm run compile",
"lint": "eslint \"./src/**/*.{js,jsx}\" \"./test/**/*.js\" \"./electron/**/*.js\" \"./config/**/*.{js,jsx}\"",
"depcheck": "depcheck",
"test-ci": "npm run test"
"test-ci": "npm run test",
"bootstrap": "node ../../scripts/download-akzidenz.js && npm run compile"
},
"license": "SSPL",
"peerDependencies": {
Expand Down
5 changes: 3 additions & 2 deletions packages/compass-collection/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,10 +23,11 @@
"test-check-ci": "npm run cover && npm run test:karma && npm run check",
"precheck": "npm run compile",
"check": "npm run lint && npm run depcheck",
"prepare": "node ../../scripts/download-akzidenz.js && npm run compile",
"prepublishOnly": "npm run compile",
"lint": "eslint \"./src/**/*.{js,jsx}\" \"./test/**/*.js\" \"./electron/**/*.js\" \"./config/**/*.{js,jsx}\"",
"depcheck": "depcheck",
"test-ci": "npm run test"
"test-ci": "npm run test",
"bootstrap": "node ../../scripts/download-akzidenz.js && npm run compile"
},
"license": "SSPL",
"peerDependencies": {
Expand Down
5 changes: 3 additions & 2 deletions packages/compass-connect/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,11 +25,12 @@
"cover": "nyc npm run test:mocha",
"precheck": "npm run compile",
"check": "npm run lint && npm run depcheck",
"prepare": "node ../../scripts/download-akzidenz.js && npm run compile",
"prepublishOnly": "npm run compile",
"lint": "eslint \"./src/**/*.{js,jsx}\" \"./test/**/*.js\" \"./electron/**/*.js\" \"./config/**/*.{js,jsx}\"",
"depcheck": "depcheck",
"test-ci": "npm run test",
"posttest-ci": "node ../../scripts/killall-mongo.js"
"posttest-ci": "node ../../scripts/killall-mongo.js",
"bootstrap": "node ../../scripts/download-akzidenz.js && npm run compile"
},
"license": "SSPL",
"peerDependencies": {
Expand Down
5 changes: 3 additions & 2 deletions packages/compass-crud/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,9 +27,10 @@
"depcheck": "depcheck",
"lint": "eslint \"./src/**/*.{js,jsx}\" \"./test/**/*.js\" \"./electron/**/*.js\" \"./config/**/*.{js,jsx}\"",
"check": "npm run depcheck && npm run lint",
"prepare": "node ../../scripts/download-akzidenz.js && npm run compile",
"prepublishOnly": "npm run compile",
"test-ci": "npm run test",
"posttest-ci": "node ../../scripts/killall-mongo.js"
"posttest-ci": "node ../../scripts/killall-mongo.js",
"bootstrap": "node ../../scripts/download-akzidenz.js && npm run compile"
},
"license": "SSPL",
"peerDependencies": {
Expand Down
5 changes: 3 additions & 2 deletions packages/compass-database/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,10 +17,11 @@
"cover": "nyc npm run test",
"test-check-ci": "npm run cover && npm run test:karma && npm run compile && npm run check",
"check": "npm run lint && npm run depcheck",
"prepare": "node ../../scripts/download-akzidenz.js && npm run compile",
"prepublishOnly": "npm run compile",
"lint": "eslint \"./src/**/*.{js,jsx}\" \"./test/**/*.js\" \"./electron/**/*.js\" \"./config/**/*.{js,jsx}\"",
"depcheck": "depcheck",
"test-ci": "npm run test"
"test-ci": "npm run test",
"bootstrap": "node ../../scripts/download-akzidenz.js && npm run compile"
},
"license": "SSPL",
"peerDependencies": {
Expand Down
5 changes: 3 additions & 2 deletions packages/compass-deployment-awareness/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,10 +23,11 @@
"test-check-ci": "npm run cover && npm run test:karma && npm run compile && npm run check",
"precheck": "npm run compile",
"check": "npm run lint && npm run depcheck",
"prepare": "node ../../scripts/download-akzidenz.js && npm run compile",
"prepublishOnly": "npm run compile",
"lint": "eslint \"./src/**/*.{js,jsx}\" \"./test/**/*.js\" \"./electron/**/*.js\" \"./config/**/*.{js,jsx}\"",
"depcheck": "depcheck",
"test-ci": "npm run test"
"test-ci": "npm run test",
"bootstrap": "node ../../scripts/download-akzidenz.js && npm run compile"
},
"license": "SSPL",
"peerDependencies": {
Expand Down
5 changes: 3 additions & 2 deletions packages/compass-explain-plan/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,10 +18,11 @@
"cover": "nyc npm run test",
"test-check-ci": "npm run cover && npm run test:karma && npm run compile && npm run check",
"check": "npm run lint && npm run depcheck",
"prepare": "node ../../scripts/download-akzidenz.js && npm run compile",
"prepublishOnly": "npm run compile",
"lint": "eslint \"./src/**/*.{js,jsx}\" \"./test/**/*.js\" \"./electron/**/*.js\" \"./config/**/*.{js,jsx}\"",
"depcheck": "depcheck",
"test-ci": "npm run test"
"test-ci": "npm run test",
"bootstrap": "node ../../scripts/download-akzidenz.js && npm run compile"
},
"license": "SSPL",
"peerDependencies": {
Expand Down
5 changes: 3 additions & 2 deletions packages/compass-export-to-language/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,10 +18,11 @@
"cover": "nyc npm run test",
"test-check-ci": "npm run check && npm run cover && npm run test:karma",
"check": "npm run lint && npm run depcheck",
"prepare": "node ../../scripts/download-akzidenz.js && npm run compile",
"prepublishOnly": "npm run compile",
"lint": "eslint \"./src/**/*.{js,jsx}\" \"./test/**/*.js\" \"./electron/**/*.js\" \"./config/**/*.{js,jsx}\"",
"depcheck": "depcheck",
"test-ci": "npm run test"
"test-ci": "npm run test",
"bootstrap": "node ../../scripts/download-akzidenz.js && npm run compile"
},
"license": "SSPL",
"peerDependencies": {
Expand Down
3 changes: 2 additions & 1 deletion packages/compass-field-store/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,8 @@
"lint": "eslint \"./src/**/*.{js,jsx}\" \"./test/**/*.js\" \"./electron/**/*.js\" \"./config/**/*.{js,jsx}\"",
"depcheck": "depcheck",
"test-ci": "npm run test",
"prepare": "npm run compile"
"prepublishOnly": "npm run compile",
"bootstrap": "npm run compile"
},
"license": "SSPL",
"peerDependencies": {
Expand Down
3 changes: 2 additions & 1 deletion packages/compass-find-in-page/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,8 @@
"lint": "eslint \"./src/**/*.{js,jsx}\" \"./test/**/*.js\" \"./electron/**/*.js\" \"./config/**/*.{js,jsx}\"",
"depcheck": "depcheck",
"test-ci": "npm run test",
"prepare": "npm run compile"
"prepublishOnly": "npm run compile",
"bootstrap": "npm run compile"
},
"license": "SSPL",
"peerDependencies": {
Expand Down
5 changes: 3 additions & 2 deletions packages/compass-home/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,10 +18,11 @@
"cover": "nyc npm run test",
"precheck": "cross-env NODE_ENV=production webpack --config ./config/webpack.prod.config.js",
"check": "npm run lint && npm run depcheck",
"prepare": "node ../../scripts/download-akzidenz.js && npm run compile",
"prepublishOnly": "npm run compile",
"lint": "eslint \"./src/**/*.{js,jsx}\" \"./test/**/*.js\" \"./electron/**/*.js\" \"./config/**/*.{js,jsx}\"",
"depcheck": "depcheck",
"test-ci": "npm run test"
"test-ci": "npm run test",
"bootstrap": "node ../../scripts/download-akzidenz.js && npm run compile"
},
"license": "SSPL",
"peerDependencies": {
Expand Down
5 changes: 3 additions & 2 deletions packages/compass-import-export/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,10 +24,11 @@
"test:dev": "cross-env NODE_ENV=test mocha-webpack",
"cover": "nyc npm run test",
"check": "npm run lint && npm run depcheck",
"prepare": "node ../../scripts/download-akzidenz.js && npm run compile",
"prepublishOnly": "npm run compile",
"lint": "eslint \"./src/**/*.{js,jsx}\" \"./test/**/*.js\"",
"depcheck": "depcheck",
"test-ci": "npm run test"
"test-ci": "npm run test",
"bootstrap": "node ../../scripts/download-akzidenz.js && npm run compile"
},
"license": "SSPL",
"peerDependencies": {
Expand Down
5 changes: 3 additions & 2 deletions packages/compass-indexes/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,10 +18,11 @@
"cover": "nyc npm run test",
"test-check-ci": "npm run cover && npm run test:karma && npm run compile && npm run check",
"check": "npm run lint && npm run depcheck",
"prepare": "node ../../scripts/download-akzidenz.js && npm run compile",
"prepublishOnly": "npm run compile",
"lint": "eslint \"./src/**/*.{js,jsx}\" \"./test/**/*.js\" \"./electron/**/*.js\" \"./config/**/*.{js,jsx}\"",
"depcheck": "depcheck",
"test-ci": "npm run test"
"test-ci": "npm run test",
"bootstrap": "node ../../scripts/download-akzidenz.js && npm run compile"
},
"license": "SSPL",
"peerDependencies": {
Expand Down
5 changes: 3 additions & 2 deletions packages/compass-instance/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,10 +22,11 @@
"test-check-ci": "npm run cover && npm run test:karma && npm run compile && npm run check",
"precheck": "npm run compile",
"check": "npm run lint && npm run depcheck",
"prepare": "node ../../scripts/download-akzidenz.js && npm run compile",
"prepublishOnly": "npm run compile",
"lint": "eslint \"./src/**/*.{js,jsx}\" \"./test/**/*.js\" \"./electron/**/*.js\" \"./config/**/*.{js,jsx}\"",
"depcheck": "depcheck",
"test-ci": "npm run test"
"test-ci": "npm run test",
"bootstrap": "node ../../scripts/download-akzidenz.js && npm run compile"
},
"license": "SSPL",
"peerDependencies": {
Expand Down
5 changes: 3 additions & 2 deletions packages/compass-loading/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,10 +17,11 @@
"cover": "nyc npm run test",
"test-check-ci": "npm run cover && npm run test:karma && npm run compile && npm run check",
"check": "npm run lint && npm run depcheck",
"prepare": "node ../../scripts/download-akzidenz.js && npm run compile",
"prepublishOnly": "npm run compile",
"lint": "eslint \"./src/**/*.{js,jsx}\" \"./test/**/*.js\" \"./electron/**/*.js\" \"./config/**/*.{js,jsx}\"",
"depcheck": "depcheck",
"test-ci": "npm run test"
"test-ci": "npm run test",
"bootstrap": "node ../../scripts/download-akzidenz.js && npm run compile"
},
"license": "SSPL",
"peerDependencies": {
Expand Down
5 changes: 3 additions & 2 deletions packages/compass-metrics/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,10 +17,11 @@
"cover": "nyc npm run test",
"test-check-ci": "npm run cover && npm run compile && npm run check",
"check": "npm run lint && npm run depcheck",
"prepare": "node ../../scripts/download-akzidenz.js && npm run compile",
"prepublishOnly": "npm run compile",
"lint": "eslint \"./src/**/*.{js,jsx}\" \"./test/**/*.js\" \"./electron/**/*.js\" \"./config/**/*.{js,jsx}\"",
"depcheck": "depcheck",
"test-ci": "npm run test"
"test-ci": "npm run test",
"bootstrap": "node ../../scripts/download-akzidenz.js && npm run compile"
},
"license": "SSPL",
"peerDependencies": {
Expand Down
Loading