Skip to content

Conversation

mcasimir
Copy link
Collaborator

@mcasimir mcasimir commented Mar 2, 2022

Description

Checklist

  • New tests and/or benchmarks are included
  • Documentation is changed or added

Motivation and Context

  • Bugfix
  • New feature
  • Dependency update
  • Misc

Open Questions

Dependents

Types of changes

  • Backport Needed
  • Patch (non-breaking change which fixes an issue)
  • Minor (non-breaking change which adds functionality)
  • Major (fix or feature that would cause existing functionality to change)

Copy link
Member

@Anemy Anemy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! Happy to have 1 ci

# Matches what we are doing in Evergreen
MONGODB_VERSION: '4'
run: COMPASS_RUN_DOCKER_TESTS=true npm run test --workspace mongodb-data-service
run: COMPASS_RUN_DOCKER_TESTS=true npm run test-connectivity --workspace mongodb-data-service
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this not running the connectivity tests previously or are we accounting for a recent change here?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is a recent improvement test-connectivity only runs connectivity tests, before was running all the tests in data-service and the connectivity tests

@mcasimir mcasimir merged commit 374f059 into main Mar 3, 2022
@mcasimir mcasimir deleted the move-prs-to-evg branch March 3, 2022 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants