Skip to content

chore(ci): remove tasks moved to EVG #2854

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 3, 2022
Merged

chore(ci): remove tasks moved to EVG #2854

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e4750e4
chore: remove moved jobs
mcasimir Mar 2, 2022
3efa187
remove all the github tests
mcasimir Mar 2, 2022
9a820a9
re-add e2e tests for OSX
mcasimir Mar 3, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
90 changes: 0 additions & 90 deletions .github/workflows/check-test.yaml
View file
Open in desktop

This file was deleted.

2 changes: 1 addition & 1 deletion .github/workflows/connectivity-tests.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,5 +110,5 @@ jobs:
E2E_TESTS_ATLAS_X509_PEM: ${{ secrets.E2E_TESTS_ATLAS_X509_PEM }}
# Matches what we are doing in Evergreen
MONGODB_VERSION: '4'
run: COMPASS_RUN_DOCKER_TESTS=true npm run test --workspace mongodb-data-service
run: COMPASS_RUN_DOCKER_TESTS=true npm run test-connectivity --workspace mongodb-data-service
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this not running the connectivity tests previously or are we accounting for a recent change here?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is a recent improvement test-connectivity only runs connectivity tests, before was running all the tests in data-service and the connectivity tests

shell: bash
29 changes: 10 additions & 19 deletions .github/workflows/build.yaml → .github/workflows/e2e-tests-osx.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,23 +1,24 @@
# This action runs lint checks and tests against the code.
name: Build Compass
# Run e2e tests on osx since in EVG are currently disabled due
# to issues with unlocking keytar.
name: E2e Tests OSX

# Controls when the action will run.
on:
pull_request:

# Allows you to run this workflow manually from the Actions tab
workflow_dispatch:
push:
branches:
- main

# A workflow run is made up of one or more jobs that can run sequentially or in parallel
jobs:
build:
name: Build Compass
build-and-test:
name: Package and Run E2e Tests on OSX

timeout-minutes: 45

strategy:
matrix:
os: [ubuntu-latest, windows-latest, macos-latest]
os: [macos-latest]

fail-fast: false

Expand All @@ -26,10 +27,6 @@ jobs:

# Steps represent a sequence of tasks that will be executed as part of the job
steps:
- name: Install Deps Ubuntu
if: ${{ runner.os == 'Linux' }}
run: sudo apt-get -y install libkrb5-dev libsecret-1-dev net-tools libstdc++6 gnome-keyring

# Checks-out your repository under $GITHUB_WORKSPACE, so your job can access it
- name: Checkout
uses: actions/checkout@v2
Expand Down Expand Up @@ -64,12 +61,6 @@ jobs:
# We don't need to bootstrap anything else before running the e2e tests
npx lerna run bootstrap -- --stream --scope @mongodb/webpack-config-compass

# https://github.community/t/set-path-for-wix-toolset-in-windows-runner/154708/3
- name: Set path for candle.exe and light.exe
if: ${{ runner.os == 'Windows' }}
run: echo "C:\Program Files (x86)\WiX Toolset v3.11\bin" >> $GITHUB_PATH
shell: bash

- name: Build Compass
env:
DEBUG: 'hadron*,mongo*,electron*'
Expand Down Expand Up @@ -114,4 +105,4 @@ jobs:
if: always()
with:
name: Webdriverio Debug Files ${{ github.workflow }} ${{ runner.os }}
path: packages/compass-e2e-tests/.log/**/*
path: packages/compass-e2e-tests/.log/**/*