chore(e2e): Don't do the "first run experience" every time COMPASS-5262

[lerouxb]

Basically: only calculate a userDataDir once. Only delete it if/when we ask for the "firstRun" experience explicitly and then during cleanup after all the tests.

[lerouxb]

The windows flake is just the same windows flake we're trying to fix elsewhere: #2891 (comment)

[addaleax]

Is there a specific reason that this method needs to be synchronous?

[lerouxb]

cleanup() in index.ts is synchronous and I need to call it there.

[lerouxb]

See

compass/packages/compass-e2e-tests/index.ts

Lines 50 to 74 in a58edee

	function cleanup() {
	keychain.reset();
	const disableStartStop = process.argv.includes('--disable-start-stop');
	if (!disableStartStop) {
	debug('Stopping MongoDB server and cleaning up server data');
	try {
	crossSpawn.sync('npm', ['run', 'stop-server'], {
	// If it's taking too long we might as well kill the process and move on,
	// mongodb-runer is flaky sometimes and in ci `posttest-ci` script will
	// take care of additional clean up anyway
	timeout: 30_000,
	stdio: 'inherit',
	});
	} catch (e) {
	debug('Failed to stop MongoDB Server', e);
	}
	try {
	fs.rmdirSync('.mongodb', { recursive: true });
	} catch (e) {
	debug('Failed to clean up server data', e);
	}
	}
	}