fix: search by collection name #2891
Conversation
|
lol |
| it('can create a collection and drop it', async function () { | ||
| const dbName = 'test'; // existing db | ||
| const collectionName = 'my-sidebar-collection'; | ||
| const collectionName = 'a-sidebar-collection'; |
There was a problem hiding this comment.
why not just search in the sidebar so it is the only one being displayed?
There was a problem hiding this comment.
see helpers/commands/navigate-to-collection-tab.js for how to do that.
There was a problem hiding this comment.
ah damn. i didn't know that we can also search by collection name. that sounds much better. I always tried db.collection but of course it didn't work.
There was a problem hiding this comment.
I'm happy with this either way, btw. A third way to fix this would be to extend helpers/compass/scroll-to-virtual-item.ts to work with the sidebar which I think also uses virtual scrolling.
There might be a race condition with searching: if you search before the collection exists it will never find it. In that case your original solution of putting it at the front is fine for now.
|
I don't mind trying to fix this as well - I probably broke it when I added lots of collections. I think the way to go is to make |
mabaasit
changed the title
3 participants
this PR fixes the broken test that was introduced in #2867
Due to less scroll area of sidebar databases, the
database.collectionis not visible in the viewport and test fails.Now changed search param to collection name.
Description
Checklist
Motivation and Context
Open Questions
Dependents
Types of changes