fix(test): scroll virtual tree #2895
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Follow up from #2891 |
|
I think we just need to scroll in the other places we use the sidebar database/collections as well. |
lerouxb
approved these changes
Mar 15, 2022
lerouxb
reviewed
Mar 15, 2022
| scrollTop, | ||
| // Due to interprocess, we can not pass a function here. | ||
| // So, we stringify it here and then eval to execute it | ||
| config.getScrollContainer.toString() |
There was a problem hiding this comment.
It is a pity. I guess whatever magic they do to make browser.execute() work doesn't extend to parameters.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Checklist
Motivation and Context
Open Questions
Dependents
Types of changes