Skip to content

fix(connect-form): allow empty hosts #3065

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 10, 2022
Merged

fix(connect-form): allow empty hosts #3065

merged 1 commit into from
May 10, 2022

Conversation

mcasimir
Copy link
Collaborator

@mcasimir mcasimir commented May 9, 2022 •
edited
Loading

Fixes:

"Selecting the whole host and trying to delete it keeps the value in the form but also shows a bunch of errors"

image

With the loose validation in ConnectionString is possible to leave the host empty. Also edge cases like mongodb://,,,/ are handled just fine.

@mcasimir mcasimir requested a review from Anemy May 9, 2022 13:05
Anemy
Anemy approved these changes May 9, 2022
View reviewed changes
Copy link
Member

@Anemy Anemy left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! Tried it out and it works smooth. I think this check was preventing an edge case that went away with improvements to how we were storing the connection string being edited.

@mcasimir mcasimir merged commit 6b393a5 into main May 10, 2022
@mcasimir mcasimir deleted the remove-hosts-check branch May 10, 2022 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Anemy Anemy Anemy approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mcasimir @Anemy