Skip to content

fix(connect-form): allow empty hosts #3065

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 10, 2022
Merged

fix(connect-form): allow empty hosts #3065

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 7 additions & 14 deletions packages/connection-form/src/hooks/use-connect-form.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -372,26 +372,19 @@ describe('use-connect-form hook', function () {
);
});

it('adds an error to the errors with a message and the host field name', function () {
expect(updateResult.errors).to.deep.equal([
{
fieldName: 'hosts',
fieldIndex: 0,
fieldTab: 'general',
message:
'Host cannot be empty. The host is the address hostname, IP address, or UNIX domain socket where the mongodb instance is running.',
},
]);
it('does not add an error to the errors', function () {
expect(updateResult.errors).to.deep.equal([]);
});

it('keeps the connection string and url the same', function () {
it('produces a well formed connection string', function () {
expect(
new ConnectionStringUrl(
updateResult.connectionOptions.connectionString
updateResult.connectionOptions.connectionString,
{ looseValidation: true }
).hosts
).to.deep.equal(['outerspace:27019']);
).to.deep.equal(['']);
expect(updateResult.connectionOptions.connectionString).to.equal(
'mongodb://outerspace:27019/?ssl=true&directConnection=true'
'mongodb:///?ssl=true&directConnection=true'
);
});
});
Expand Down
6 changes: 0 additions & 6 deletions packages/connection-form/src/hooks/use-connect-form.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -227,12 +227,6 @@ function handleUpdateHost({
try {
checkForInvalidCharacterInHost(newHostValue, connectionStringUrl.isSRV);

if (connectionStringUrl.hosts.length === 1 && newHostValue === '') {
throw new Error(
'Host cannot be empty. The host is the address hostname, IP address, or UNIX domain socket where the mongodb instance is running.'
);
}

const updatedConnectionString = connectionStringUrl.clone();
updatedConnectionString.hosts[fieldIndex] = newHostValue || '';

Expand Down