-
Notifications
You must be signed in to change notification settings - Fork 235
feat(explain-aggregation): explain aggregation COMPASS-5788 #3102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…show-explain-results
packages/compass-aggregations/src/components/pipeline-explain/explain-error.tsx
Outdated
Show resolved
Hide resolved
packages/compass-aggregations/src/components/pipeline-explain/explain-indexes.tsx
Show resolved
Hide resolved
packages/compass-aggregations/src/utils/cancellable-aggregation.ts
Outdated
Show resolved
Hide resolved
…n.ts Co-authored-by: Anna Henningsen <anna.henningsen@mongodb.com>
…b-js/compass into COMPASS-5788-show-explain-results
packages/compass-aggregations/src/components/pipeline-explain/explain-results.tsx
Outdated
Show resolved
Hide resolved
packages/compass-aggregations/src/components/pipeline-explain/index.tsx
Outdated
Show resolved
Hide resolved
packages/compass-aggregations/src/components/pipeline-explain/index.tsx
Outdated
Show resolved
Hide resolved
packages/compass-aggregations/src/components/pipeline-explain/index.tsx
Outdated
Show resolved
Hide resolved
)} | ||
<Card className={cardStyles} data-testid="pipeline-explain-results-json"> | ||
<Document | ||
doc={doc} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As we recently discovered re-creating HadronDocument
in render is really not great so instead of passing a document instance created on every render, you can pass the object that the document is based on instead
doc={doc} | |
doc={plan} |
The memoization of the HadronDocument
instance will be handled by the Document
component itself
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like showExplainButton
is only gated by the feature flag. Is the plan to support it in the Cloud right away?
…b-js/compass into COMPASS-5788-show-explain-results
Co-authored-by: Sergey Petushkov <petushkov.sergey@gmail.com>
…b-js/compass into COMPASS-5788-show-explain-results
…b-js/compass into COMPASS-5788-show-explain-results
packages/compass-aggregations/src/components/pipeline-explain/explain-query-performance.tsx
Outdated
Show resolved
Hide resolved
packages/compass-aggregations/src/components/pipeline-explain/explain-results.tsx
Outdated
Show resolved
Hide resolved
packages/compass-aggregations/src/components/pipeline-explain/explain-query-performance.tsx
Outdated
Show resolved
Hide resolved
|
||
const cardStyles = css({ | ||
// 170px works with minimum-height of compass | ||
// todo: handle height for bigger sized compass |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As an addition to this TODO, currently because "copy to clipboard" button is part of the Document component and not the card, the whole thing scrolls including the button:
I think we might want to set the height here on the document fields container and not the wrapper card as a way to prevent it, but there is no way to do it now, we would need to change the component interface a bit, and it's a very small thing so totally can be addressed later
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sure :)
…explain-query-performance.tsx Co-authored-by: Sergey Petushkov <petushkov.sergey@gmail.com>
…show-explain-results
…b-js/compass into COMPASS-5788-show-explain-results
feat(explain-aggregation): explain aggregation COMPASS-5788
Explain:
Explain.mov
Datalake Explain:
Screen.Recording.2022-05-17.at.12.54.34.mov
Error state:
Description
Checklist
Motivation and Context
Open Questions
Dependents
Types of changes