INT-1280 Fix sign_with_params typo #322
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kangas
force-pushed
the
INT-1280_pass-signtool-params-to-winstaller
branch
from
2137f07 to
d40c5a6
Compare
Make the signtool.exe sitting in our current working directory executable. Remove the copy to electron-winstaller's vendor directory. In Squirrel.Windows/src/Update/Program.cs, function signPEFile: search order for "signtool.exe" is: - first: ".\signtool.exe" - second: GetExecutingAssembly().Location - "Run down PATH and hope for the best" source: https://github.com/Squirrel/Squirrel.Windows/blob/b814ada81a0060be22ec2f24efb6be0ff8c16d95/src/Update/Program.cs#L577-L588
kangas
force-pushed
the
INT-1280_pass-signtool-params-to-winstaller
branch
from
d40c5a6 to
9951185
Compare
|
Patch build for latest changes: https://evergreen.mongodb.com/version/56ec769c3ff1225c6e001868_0 |
|
|
|
Verified on Windows 10. It's fixed. |
kangas
added a commit
that referenced
this pull request
Mar 18, 2016
…installer 🐛 🏁 Fix sign_with_params typo
kangas
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is