Skip to content

INT-1280 Fix sign_with_params typo #322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 18, 2016
Merged

INT-1280 Fix sign_with_params typo #322

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
61386d0
:bug: :checkered_flag: INT-1280 Fix sign_with_params typo
imlucas Mar 16, 2016
9951185
INT-1280 fix Windows signing
kangas Mar 18, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions .evergreen.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,8 +89,7 @@ functions:
-o "signtool.exe" \
--url "https://s3.amazonaws.com/boxes.10gen.com/build/signtool.exe"
rm -f node_modules/electron-winstaller/vendor/signtool.exe
cp signtool.exe node_modules/electron-winstaller/vendor/signtool.exe
chmod +x node_modules/electron-winstaller/vendor/signtool.exe
chmod +x signtool.exe
# Environment variables set for use by notary-service signtool.exe on Windows:
# NOTARY_URL, NOTARY_AUTH_TOKEN, NOTARY_SIGNING_KEY, NOTARY_SIGNING_COMMENT
Expand Down
2 changes: 1 addition & 1 deletion scripts/config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -262,7 +262,7 @@ exports.get = function(cli, callback) {
authors: CONFIG['version-string'].CompanyName,
version: CONFIG['app-version'],
exe: format('%s.exe', CONFIG.name),
signWithParams: CONFIG.signtool_params,
signWithParams: CONFIG.sign_with_params,
loadingGif: CONFIG.loading_gif,
title: CONFIG.name,
productName: CONFIG.name,
Expand Down