INT-1650: Fix TypeError: Property 'ssh_tunnel_port' must be of type number #441
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…umber The form default view is `’’` which is false-y so we were trying to set an empty string as a number.
|
Heh! That's pretty easy. I'll test manually. |
|
On this branch, fresh install ( When I try the following config (see screenshot) and click "Connect", I briefly see the progress bar, then it disappears. These bugsnag events are me: (Same error, "Uncaught TypeError: Property 'ssh_tunnel_port' must be of type number. Tried to set") |
mongodb-js/connection-model#87 - All logic in one place for easier DX and release management - Refactor `connect()` so if you specify ssh tunnel options, it all just works. - New `status` events to enable live updating status bars @rueckstiess would like to implement. - This will be an `npm version major` and subsequent major of data-service.
|
@kangas What screenshot are you referring to? I do not get that error on this branch locally. |
kangas
pushed a commit
that referenced
this pull request
Aug 16, 2016
…umber (#441) * INT-1650: Fix TypeError: Property 'ssh_tunnel_port' must be of type number The form default view is `’’` which is false-y so we were trying to set an empty string as a number. * ⬆️ mongodb-connection-model@5.0.0 mongodb-js/connection-model#87 - All logic in one place for easier DX and release management - Refactor `connect()` so if you specify ssh tunnel options, it all just works. - New `status` events to enable live updating status bars @rueckstiess would like to implement. - This will be an `npm version major` and subsequent major of data-service. * ⬆️ mongodb-data-service@1.0.0 * data-service@1.0.0 uses standard node.js style event names (cherry picked from commit ac08030)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The form default view is
’’which is false-y so we were trying to setan empty string as a number.
This change is