This repository was archived by the owner on May 31, 2022. It is now read-only.
INT-1650: SSH tunnel #87
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Move ssh_tunnel tests to their own module - Add `port` dataType that is much easier to use with form inputs and handles all casting & validation in a single code path - Add more tests
- All logic in one place for easier DX and release management - Refactor `connect()` so if you specify ssh tunnel options, it all just works. - New `status` events to enable live updating status bars @rueckstiess would like to implement. - This will be an `npm version major` and subsequent major of data-service.
|
@imlucas, thanks for your PR! By analyzing the annotation information on this pull request, we identified @durran, @rueckstiess and @greenkeeperio-bot to be potential reviewers |
imlucas
added a commit
to mongodb-js/data-service
that referenced
this pull request
Jul 25, 2016
Depends on mongodb-js/connection-model#87 being merged and published. Then updating mongodb-connection-model in package.json.
|
👍 |
imlucas
added a commit
to mongodb-js/compass
that referenced
this pull request
Jul 26, 2016
mongodb-js/connection-model#87 - All logic in one place for easier DX and release management - Refactor `connect()` so if you specify ssh tunnel options, it all just works. - New `status` events to enable live updating status bars @rueckstiess would like to implement. - This will be an `npm version major` and subsequent major of data-service.
imlucas
added a commit
to mongodb-js/data-service
that referenced
this pull request
Jul 26, 2016
* INT-1650: Make ssh tunnels easier to debug * Move SSH Tunnel to mongodb-connection-model Depends on mongodb-js/connection-model#87 being merged and published. Then updating mongodb-connection-model in package.json. * ⬆️ mongodb-connection-model@5.0.0 * 📝 🎨 Remove `Events` and give README some love * 💚 * 👔
durran
pushed a commit
to mongodb-js/compass
that referenced
this pull request
Aug 8, 2016
…umber (#441) * INT-1650: Fix TypeError: Property 'ssh_tunnel_port' must be of type number The form default view is `’’` which is false-y so we were trying to set an empty string as a number. * ⬆️ mongodb-connection-model@5.0.0 mongodb-js/connection-model#87 - All logic in one place for easier DX and release management - Refactor `connect()` so if you specify ssh tunnel options, it all just works. - New `status` events to enable live updating status bars @rueckstiess would like to implement. - This will be an `npm version major` and subsequent major of data-service. * ⬆️ mongodb-data-service@1.0.0 * data-service@1.0.0 uses standard node.js style event names
kangas
pushed a commit
to mongodb-js/compass
that referenced
this pull request
Aug 16, 2016
…umber (#441) * INT-1650: Fix TypeError: Property 'ssh_tunnel_port' must be of type number The form default view is `’’` which is false-y so we were trying to set an empty string as a number. * ⬆️ mongodb-connection-model@5.0.0 mongodb-js/connection-model#87 - All logic in one place for easier DX and release management - Refactor `connect()` so if you specify ssh tunnel options, it all just works. - New `status` events to enable live updating status bars @rueckstiess would like to implement. - This will be an `npm version major` and subsequent major of data-service. * ⬆️ mongodb-data-service@1.0.0 * data-service@1.0.0 uses standard node.js style event names (cherry picked from commit ac08030)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
connect()so if you specify ssh tunnel options, it alljust works.
statusevents to enable live updating status bars @rueckstiesswould like to implement.
npm version majorand subsequent major ofdata-service.
This change is