Skip to content

fix(search-indexes): smaller column widths COMPASS-7341 #4989

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 16, 2023
Merged

fix(search-indexes): smaller column widths COMPASS-7341 #4989

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bba0568
column widths
mabaasit Oct 13, 2023
edc51f5
Merge branch 'main' of github.com:mongodb-js/compass into COMPASS-734…
mabaasit Oct 13, 2023
b67ed33
bootstrap
mabaasit Oct 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 8 additions & 2 deletions packages/compass-indexes/src/components/indexes-table/indexes-table.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,11 @@ const indexActionsCellStyles = css({
minWidth: spacing[5],
});

const indexActionsCellContainerStyles = css({
display: 'flex',
justifyContent: 'flex-end',
});

const tableHeaderStyles = css({
borderWidth: 0,
borderBottomWidth: 3,
Expand Down Expand Up @@ -78,6 +83,7 @@ type IndexInfo = {
key?: string;
'data-testid': string;
children: React.ReactNode;
className?: string;
}[];
actions?: React.ReactNode;
details?: React.ReactNode;
Expand Down Expand Up @@ -185,7 +191,7 @@ export function IndexesTable<Column extends string>({
<Cell
key={field.key ?? `${info.key}-${index}`}
data-testid={`${dataTestId}-${field['data-testid']}`}
className={cellStyles}
className={cx(cellStyles, field.className)}
>
{field.children}
</Cell>
Expand All @@ -195,7 +201,7 @@ export function IndexesTable<Column extends string>({
{canModifyIndex && (
<Cell
data-testid={`${dataTestId}-actions-field`}
className={cellStyles}
className={cx(cellStyles, indexActionsCellContainerStyles)}
>
{info.actions && (
<div
Expand Down
6 changes: 6 additions & 0 deletions packages/compass-indexes/src/components/search-indexes-table/search-indexes-table.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -202,10 +202,16 @@ export const SearchIndexesTable: React.FunctionComponent<
fields: [
{
'data-testid': 'name-field',
className: css({
width: '30%',
}),
children: index.name,
},
{
'data-testid': 'status-field',
className: css({
width: '20%',
}),
children: (
<IndexStatus
status={index.status}
Expand Down