COMPASS-132: Fix Intercom email can't be blank error #534
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The below started appearing when intercom messenger was upgraded
several weeks ago. The root cause is user resource would send
`email:‘’` which fails validation on Intercom's API server. If we
instead allow email to default to undefined, no empty string is sent to
intercom’s server and validation passes. After this is merged, we’ll
also need to change models/user.js in Compass.
```
Failed to load resource: the server responded with a status of 400 (Bad
Request)
Uncaught (in promise
{"type":"error.list","request_id":"anscsvqg0eamtn7i98t0","errors":[{"cod
e":"parameter_invalid","message":"Email can't be blank"}]}
```
20 tasks
|
LGTM |
imlucas
changed the title
imlucas
added a commit
that referenced
this pull request
Oct 25, 2016
The below started appearing when intercom messenger was upgraded
several weeks ago. The root cause is user resource would send
`email:‘’` which fails validation on Intercom's API server. If we
instead allow email to default to undefined, no empty string is sent to
intercom’s server and validation passes. After this is merged, we’ll
also need to change models/user.js in Compass.
```
Failed to load resource: the server responded with a status of 400 (Bad
Request)
Uncaught (in promise
{"type":"error.list","request_id":"anscsvqg0eamtn7i98t0","errors":[{"cod
e":"parameter_invalid","message":"Email can't be blank"}]}
```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The below started appearing when intercom messenger was upgraded
several weeks ago. The root cause is user resource would send
email:‘’which fails validation on Intercom's API server. If weinstead allow email to default to undefined, no empty string is sent to
intercom’s server and validation passes. After this is merged, we’ll
also need to change models/user.js in Compass.