Skunkworks: Compass things I've been meaning to get around to for a while #522
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Makes for much simpler debugging or both react components and electron. These devtools extensions are only loaded and activated when Compass is in development mode. ## [react devtools](https://fb.me/react-devtools) > React Developer Tools is a Chrome DevTools extension for the open-source React JavaScript library. It allows you to inspect the React component hierarchies in the Chrome Developer Tools.  ## [devtron](http://electron.atom.io/devtron/) > Devtron is an open source tool to help you inspect, monitor, and debug your Electron app. Built on top of the amazing Chrome Developer Tools. 
imlucas
changed the title
Was long ago ported to react. @see ./src/internal-packages/explain
The below started appearing when intercom messenger was upgraded
several weeks ago. The root cause is user resource would send
`email:‘’` which fails validation on Intercom's API server. If we
instead allow email to default to undefined, no empty string is sent to
intercom’s server and validation passes. After this is merged, we’ll
also need to change models/user.js in Compass.
```
Failed to load resource: the server responded with a status of 400 (Bad
Request)
Uncaught (in promise
{"type":"error.list","request_id":"anscsvqg0eamtn7i98t0","errors":[{"cod
e":"parameter_invalid","message":"Email can't be blank"}]}
```
Were ported to react some time ago. See ./src/internal-packages/schema
``` /Users/lucas/compass/node_modules/fbjs/lib/warning.js:36 Warning: Failed prop type: Invalid prop `alignItems` of value `start` supplied to `FlexBox`, expected one of ["flex-start","flex-end","center","stretch","baseline"]. ```
imlucas
changed the title
makes migration to a compass package easier
Where they’re actually used.
|
These are great! Can we make in individual PRs for the different changes? |
|
Yep! Breaking down this morning. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Take a hatchet to old dead code
Many components already ported to React but the previous versions still hanging around.
Port to Compass packages
This will let us actually have real tests to work on in the run up to 3.4 Server release
RTSS Hacking
Other Annoyances